You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org> on 2008/08/20 10:02:44 UTC
[jira] Updated: (ZOOKEEPER-115) Potential NPE in QuorumCnxManager
[ https://issues.apache.org/jira/browse/ZOOKEEPER-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-115:
---------------------------------------------
Attachment: ZOOKEEPER-115.patch
This patches fixes the prolem pointed out by findbugs, and adds a new method to QuorumCnxManager to avoid code repetition.
> Potential NPE in QuorumCnxManager
> ---------------------------------
>
> Key: ZOOKEEPER-115
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-115
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Patrick Hunt
> Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-115.patch
>
>
> Findbugs flagged this, notice that we are checking for null after using the reference.
> if (senderWorkerMap.get(s.socket().getInetAddress()) != null) {
> senderWorkerMap.get(s.socket().getInetAddress()).finish();
> }
> /*
> * Start new worker thread with a clean state.
> */
> if (s != null) {
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.