You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@cn.ibm.com> on 2016/02/25 16:15:14 UTC
Review Request 44004: Add 'name' field into NetworkInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/
-----------------------------------------------------------
Review request for mesos, Avinash sridharan and Jie Yu.
Bugs: MESOS-4758
https://issues.apache.org/jira/browse/MESOS-4758
Repository: mesos
Description
-------
Add 'name' field into NetworkInfo.
Diffs
-----
include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06
include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1
Diff: https://reviews.apache.org/r/44004/diff/
Testing
-------
make check
Thanks,
Qian Zhang
Re: Review Request 44004: Add 'name' field into NetworkInfo.
Posted by Qian Zhang <zh...@cn.ibm.com>.
> On Feb. 25, 2016, 11:32 p.m., Avinash sridharan wrote:
> > include/mesos/v1/mesos.proto, line 1573
> > <https://reviews.apache.org/r/44004/diff/1/?file=1270995#file1270995line1573>
> >
> > Ditto.
Agree.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review120710
-----------------------------------------------------------
On Feb. 26, 2016, 10:01 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 10:01 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add 'name' field into NetworkInfo.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06
> include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1
>
> Diff: https://reviews.apache.org/r/44004/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 44004: Add 'name' field into NetworkInfo.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review120710
-----------------------------------------------------------
include/mesos/mesos.proto (line 1576)
<https://reviews.apache.org/r/44004/#comment182168>
Should we be more elaborate in our description?
Maybe:
This will be used by the container run-time to determine the network that this container joins. For e.g., for `MesosContainerizer` this would represent the CNI network to which the container will be attached.
include/mesos/v1/mesos.proto (line 1573)
<https://reviews.apache.org/r/44004/#comment182169>
Ditto.
- Avinash sridharan
On Feb. 25, 2016, 3:15 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 3:15 p.m.)
>
>
> Review request for mesos, Avinash sridharan and Jie Yu.
>
>
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add 'name' field into NetworkInfo.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06
> include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1
>
> Diff: https://reviews.apache.org/r/44004/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 44004: Add 'name' field into NetworkInfo.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review120776
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44004]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 25, 2016, 3:15 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 3:15 p.m.)
>
>
> Review request for mesos, Avinash sridharan and Jie Yu.
>
>
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add 'name' field into NetworkInfo.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06
> include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1
>
> Diff: https://reviews.apache.org/r/44004/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 44004: Add 'name' field into NetworkInfo.
Posted by Qian Zhang <zh...@cn.ibm.com>.
> On Feb. 26, 2016, 9 a.m., Avinash sridharan wrote:
> > include/mesos/mesos.proto, line 1577
> > <https://reviews.apache.org/r/44004/diff/1/?file=1270994#file1270994line1577>
> >
> > In order to expose this field in state.json, I think you need to add the filed to the corresponding `model` function in src/common/http.cpp as well.
> >
> > We won't need this once we move to the new JSONIFY api, but I think we would need it in the immediate future.
Agree.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review120810
-----------------------------------------------------------
On Feb. 26, 2016, 10:01 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 10:01 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add 'name' field into NetworkInfo.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06
> include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1
>
> Diff: https://reviews.apache.org/r/44004/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 44004: Add 'name' field into NetworkInfo.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44004/#review120810
-----------------------------------------------------------
include/mesos/mesos.proto (line 1577)
<https://reviews.apache.org/r/44004/#comment182312>
In order to expose this field in state.json, I think you need to add the filed to the corresponding `model` function in src/common/http.cpp as well.
We won't need this once we move to the new JSONIFY api, but I think we would need it in the immediate future.
- Avinash sridharan
On Feb. 25, 2016, 3:15 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44004/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 3:15 p.m.)
>
>
> Review request for mesos, Avinash sridharan and Jie Yu.
>
>
> Bugs: MESOS-4758
> https://issues.apache.org/jira/browse/MESOS-4758
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add 'name' field into NetworkInfo.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 33f6b0838360b61db70a247e5d6dfb16af15aa06
> include/mesos/v1/mesos.proto 1b0e709e76f3f6b44ab0434c649c064e8866c8a1
>
> Diff: https://reviews.apache.org/r/44004/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Qian Zhang
>
>