You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/22 23:36:41 UTC

[GitHub] [incubator-superset] ktmud opened a new pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0

ktmud opened a new pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628


   ### CATEGORY
   
   - [x] Enhancement (new features, refinement)
   
   ### SUMMARY
   
   In order to enable easy reordering of metrics select, we need to upgrade
   `react-select` v1 and v3.
   
   This is still WIP and may take quite a while to complete. Creating this PR for visibility.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   
   Ideally there should be no visible UI change.
   
   ### REVIEWERS
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `67.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   65.95%   -4.98%     
   ==========================================
     Files         183      593     +410     
     Lines       17847    30642   +12795     
     Branches        0     3200    +3200     
   ==========================================
   + Hits        12660    20211    +7551     
   - Misses       5187    10240    +5053     
   - Partials        0      191     +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.01% <67.44%> (?)` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...3106d17](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `5.06%`.
   > The diff coverage is `68.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   65.87%   -5.07%     
   ==========================================
     Files         183      592     +409     
     Lines       17847    30634   +12787     
     Branches        0     3198    +3198     
   ==========================================
   + Hits        12660    20180    +7520     
   - Misses       5187    10263    +5076     
   - Partials        0      191     +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.11% <68.22%> (?)` | |
   | #python | `70.71% <ø> (-0.22%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.66% <ø> (ø)` | |
   | [...components/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU3FsVGFiQ29udGVudC5qc3g=) | `67.64% <ø> (ø)` | |
   | ... and [454 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...0b0a699](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.06%`.
   > The diff coverage is `89.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   70.86%   -0.07%     
   ==========================================
     Files         183      593     +410     
     Lines       17847    30645   +12798     
     Branches        0     3200    +3200     
   ==========================================
   + Hits        12660    21718    +9058     
   - Misses       5187     8813    +3626     
   - Partials        0      114     +114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.99% <81.16%> (?)` | |
   | #javascript | `59.02% <67.67%> (?)` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `88.18% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...54ade59](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r421851117



##########
File path: superset-frontend/cypress-base/cypress/integration/explore/control.test.js
##########
@@ -152,16 +148,13 @@ describe('AdhocFilters', () => {
     cy.verifySliceSuccess({ waitAlias: '@postJson' });
 
     cy.get('[data-test=adhoc_filters]').within(() => {
-      cy.get('.Select-control').click({ force: true });
-      cy.get('input').type('name', { force: true });
-      cy.get('.VirtualizedSelectFocusedOption').trigger('mousedown').click();
+      cy.get('.Select__control').click();
+      cy.get('input[type=text]').type('name{enter}');

Review comment:
       The new `react-select` adds a `input:text` as well as `input:hidden` for form values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `5.02%`.
   > The diff coverage is `65.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   71.02%   65.99%   -5.03%     
   ==========================================
     Files         583      589       +6     
     Lines       30615    30614       -1     
     Branches     3162     3241      +79     
   ==========================================
   - Hits        21745    20205    -1540     
   - Misses       8759    10222    +1463     
   - Partials      111      187      +76     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `70.79% <ø> (-0.48%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.66% <ø> (-1.70%)` | :arrow_down: |
   | ... and [229 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...3bfabac](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a95c52d61efc4940348319456eab87eb531c936&el=desc) will **decrease** coverage by `5.04%`.
   > The diff coverage is `65.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   71.01%   65.97%   -5.05%     
   ==========================================
     Files         586      592       +6     
     Lines       30635    30634       -1     
     Branches     3159     3238      +79     
   ==========================================
   - Hits        21756    20210    -1546     
   - Misses       8768    10237    +1469     
   - Partials      111      187      +76     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.22% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `70.79% <ø> (-0.48%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [231 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [7a95c52...8948497](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 merged pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6df5da1950f2c88a89b9a430d4e8a59006a36d3&el=desc) will **decrease** coverage by `0.13%`.
   > The diff coverage is `89.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.78%   70.65%   -0.14%     
   ==========================================
     Files         587      593       +6     
     Lines       30456    30652     +196     
     Branches     3121     3199      +78     
   ==========================================
   + Hits        21558    21656      +98     
   - Misses       8784     8875      +91     
   - Partials      114      121       +7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.31% <81.04%> (-0.42%)` | :arrow_down: |
   | #javascript | `59.06% <68.59%> (+0.06%)` | :arrow_up: |
   | #python | `70.89% <ø> (-0.05%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `88.18% <0.00%> (+4.60%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | ... and [68 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [b6df5da...feb5cdb](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/80f834901805e5bc343617cecd5a78cc02476c96&el=desc) will **decrease** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.79%   70.71%   -0.09%     
   ==========================================
     Files         586      183     -403     
     Lines       30445    17847   -12598     
     Branches     3121        0    -3121     
   ==========================================
   - Hits        21555    12621    -8934     
   + Misses       8776     5226    -3550     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.71% <ø> (-0.22%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
   | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [80f8349...43c6fa6](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   70.90%   -0.04%     
   ==========================================
     Files         183      183              
     Lines       17847    17847              
   ==========================================
   - Hits        12660    12654       -6     
   - Misses       5187     5193       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #python | `70.90% <ø> (-0.04%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.63% <0.00%> (-0.44%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...0b0a699](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d167afb9499d7ce30c7ea763b19993af347dc23&el=desc) will **increase** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.72%   70.81%   +0.09%     
   ==========================================
     Files         584      182     -402     
     Lines       30382    17818   -12564     
     Branches     3112        0    -3112     
   ==========================================
   - Hits        21487    12618    -8869     
   + Misses       8781     5200    -3581     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.81% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
   | [...hboard/components/menu/BackgroundStyleDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvQmFja2dyb3VuZFN0eWxlRHJvcGRvd24uanN4) | | |
   | [...s/ErrorMessage/getErrorMessageComponentRegistry.ts](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL2dldEVycm9yTWVzc2FnZUNvbXBvbmVudFJlZ2lzdHJ5LnRz) | | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | | |
   | [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | | |
   | [...t-frontend/src/SqlLab/components/ColumnElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQuanN4) | | |
   | ... and [362 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5d167af...a5606a0](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-630434253


   @kristw @etr2460 This is now conflict free. Would you mind taking another look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425510784



##########
File path: superset-frontend/src/explore/constants.js
##########
@@ -53,10 +55,10 @@ export const HAVING_OPERATORS = [
   OPERATORS['>='],
   OPERATORS['<='],
 ];
-export const MULTI_OPERATORS = [OPERATORS.in, OPERATORS['not in']];
+export const MULTI_OPERATORS = new Set([OPERATORS.in, OPERATORS['not in']]);

Review comment:
       Maybe in the separate PR if that's really necessary. I don't want to break things.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r424642916



##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -67,9 +63,10 @@ export const FilterMenu = ({
           <MenuItem
             key={ft.id}
             eventKey={ft}
-            onSelect={(fltr: typeof ft) =>
-              setInternalFilters([...internalFilters, fltr])
-            }
+            // @ts-ignore

Review comment:
       > Type 'MouseEvent<{}, MouseEvent>' is missing the following properties from type '{ Header: string; id: string; value: undefined; }': Header, id, value
   
   
   Inconsistent callback function signature. onSelect in MenuItem expects an event, but the callback seems to be expecting the fltr type.
   
   Didn't want to change the actual code and didn't dig too deep into how to make it proper, since this file is going to be deprecated anyway (@nytai is working on a new ListView).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r424757660



##########
File path: superset-frontend/src/explore/components/PropertiesModal.tsx
##########
@@ -236,14 +245,14 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
               <label className="control-label" htmlFor="owners">
                 {t('Owners')}
               </label>
-              <SelectAsync
-                multi
+              <AsyncSelect
+                isMulti
                 name="owners"
                 value={owners || []}
                 loadOptions={loadOptions}

Review comment:
       You are right. Thanks for catching this! I forgot to test the properties modal in the Explore view.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r421899876



##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.less
##########
@@ -18,35 +18,10 @@
  */
 @import '../../../stylesheets/less/variables.less';
 
-.select2-highlighted > .filter_box {
-  background-color: transparent;
-  border: 1px superset @darkest;
-}
-
 .dashboard .filter_box .slice_container > div:not(.alert) {
   padding-top: 0;
 }
 
-.input-inline {
-  float: left;
-  // display: inline-block; //Ignored when float is applied. Leaving it here in case we lose the floats later.
-  padding-right: 3px;
-}

Review comment:
       This could be found in `main.less` already.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] kristw commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r421852689



##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/histogram.js
##########
@@ -72,7 +72,6 @@ export default () =>
             comparator: 'boy',
             clause: 'WHERE',
             sqlExpression: null,
-            fromFormData: true,

Review comment:
       what is this field for?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `67.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   65.95%   -4.98%     
   ==========================================
     Files         183      593     +410     
     Lines       17847    30642   +12795     
     Branches        0     3200    +3200     
   ==========================================
   + Hits        12660    20211    +7551     
   - Misses       5187    10240    +5053     
   - Partials        0      191     +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.01% <67.44%> (?)` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...3106d17](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5b430ead42c38692183a5471bf0b4bb4cb48eb20&el=desc) will **decrease** coverage by `6.49%`.
   > The diff coverage is `75.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.81%   64.31%   -6.50%     
   ==========================================
     Files         586      541      -45     
     Lines       30445    29250    -1195     
     Branches     3121     2853     -268     
   ==========================================
   - Hits        21559    18812    -2747     
   - Misses       8772    10256    +1484     
   - Partials      114      182      +68     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.00% <75.66%> (+0.27%)` | :arrow_up: |
   | #javascript | `?` | |
   | #python | `70.90% <ø> (-0.04%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `47.72% <ø> (-25.01%)` | :arrow_down: |
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <0.00%> (-55.67%)` | :arrow_down: |
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `7.40% <0.00%> (-51.86%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `50.64% <ø> (-4.49%)` | :arrow_down: |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (-5.56%)` | :arrow_down: |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (-17.65%)` | :arrow_down: |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (-66.67%)` | :arrow_down: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `51.96% <0.00%> (-31.62%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.33% <ø> (-42.67%)` | :arrow_down: |
   | ... and [239 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5b430ea...02a4e82](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r424716193



##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -67,9 +63,10 @@ export const FilterMenu = ({
           <MenuItem
             key={ft.id}
             eventKey={ft}
-            onSelect={(fltr: typeof ft) =>
-              setInternalFilters([...internalFilters, fltr])
-            }
+            // @ts-ignore

Review comment:
       The issue is the typings for react-bootstrap. If EventKey is present the callback will be called with that and not a MouseEvent, but the typings don't seem to account for that. This code is all going away soon, anyway, I wouldn't spend too much time on it 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425502573



##########
File path: superset-frontend/src/components/Select/SupersetStyledSelect.tsx
##########
@@ -0,0 +1,301 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { SyntheticEvent, MutableRefObject } from 'react';
+import { merge } from 'lodash';
+import BasicSelect, {
+  OptionTypeBase,
+  MultiValueProps,
+  FormatOptionLabelMeta,
+  ValueType,
+  SelectComponentsConfig,
+  components as defaultComponents,
+  createFilter,
+} from 'react-select';
+import Async from 'react-select/async';
+import Creatable from 'react-select/creatable';
+import AsyncCreatable from 'react-select/async-creatable';
+
+import { SelectComponents } from 'react-select/src/components';
+import {
+  SortableContainer,
+  SortableElement,
+  SortableContainerProps,
+} from 'react-sortable-hoc';
+import arrayMove from 'array-move';
+import {
+  WindowedSelectComponentType,
+  WindowedSelectProps,
+  WindowedSelect,
+  WindowedAsyncSelect,
+  WindowedCreatableSelect,
+  WindowedAsyncCreatableSelect,
+} from './WindowedSelect';
+import {
+  DEFAULT_CLASS_NAME,
+  DEFAULT_CLASS_NAME_PREFIX,
+  DEFAULT_STYLES,
+  DEFAULT_THEME,
+  DEFAULT_COMPONENTS,
+  VALUE_LABELED_STYLES,
+  PartialThemeConfig,
+  PartialStylesConfig,
+} from './styles';
+import { findValue } from './utils';
+
+const DEFAULT_WINDOW_THRESHOLD = 100;
+
+type AnyReactSelect<OptionType extends OptionTypeBase> =
+  | BasicSelect<OptionType>
+  | Async<OptionType>
+  | Creatable<OptionType>
+  | AsyncCreatable<OptionType>;
+
+export type SupersetStyledSelectProps<
+  OptionType extends OptionTypeBase,
+  T extends WindowedSelectProps<OptionType> = WindowedSelectProps<OptionType>
+> = T & {
+  // additional props for easier usage or backward compatibility
+  labelKey?: string;
+  valueKey?: string;
+  multi?: boolean;
+  clearable?: boolean;
+  sortable?: boolean;
+  ignoreAccents?: boolean;
+  creatable?: boolean;
+  selectRef?:
+    | React.RefCallback<AnyReactSelect<OptionType>>
+    | MutableRefObject<AnyReactSelect<OptionType>>;
+  getInputValue?: (selectBalue: ValueType<OptionType>) => string | undefined;
+  optionRenderer?: (option: OptionType) => React.ReactNode;
+  valueRenderer?: (option: OptionType) => React.ReactNode;
+  valueRenderedAsLabel?: boolean;
+  // callback for paste event
+  onPaste?: (e: SyntheticEvent) => void;
+  // for simplier theme overrides
+  themeConfig?: PartialThemeConfig;
+  stylesConfig?: PartialStylesConfig;
+};
+
+function styled<
+  OptionType extends OptionTypeBase,
+  SelectComponentType extends WindowedSelectComponentType<
+    OptionType
+  > = WindowedSelectComponentType<OptionType>
+>(SelectComponent: SelectComponentType) {
+  type SelectProps = SupersetStyledSelectProps<OptionType>;
+  type Components = SelectComponents<OptionType>;
+
+  const SortableSelectComponent = SortableContainer(SelectComponent, {
+    withRef: true,
+  });
+
+  // default components for the given OptionType
+  const supersetDefaultComponents: SelectComponentsConfig<OptionType> = DEFAULT_COMPONENTS;
+
+  const getSortableMultiValue = (MultiValue: Components['MultiValue']) => {
+    return SortableElement((props: MultiValueProps<OptionType>) => {
+      const onMouseDown = (e: SyntheticEvent) => {
+        e.preventDefault();
+        e.stopPropagation();
+      };
+      const innerProps = { onMouseDown };
+      return <MultiValue {...props} innerProps={innerProps} />;
+    });
+  };
+
+  /**
+   * Superset styled `Select` component. Apply Superset themed stylesheets and
+   * consolidate props API for backward compatibility with react-select v1.
+   */
+  function StyledSelect(selectProps: SelectProps) {
+    let stateManager: AnyReactSelect<OptionType>; // reference to react-select StateManager
+    const {
+      selectRef,
+      options,
+      value: value_,
+      className = DEFAULT_CLASS_NAME,
+      classNamePrefix = DEFAULT_CLASS_NAME_PREFIX,
+      themeConfig,
+      stylesConfig = {},
+

Review comment:
       Idk, I feel a separator line is useful, especially for those functional props. Can rearrange things to have less spaces.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5b430ead42c38692183a5471bf0b4bb4cb48eb20&el=desc) will **decrease** coverage by `6.49%`.
   > The diff coverage is `75.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.81%   64.31%   -6.50%     
   ==========================================
     Files         586      541      -45     
     Lines       30445    29250    -1195     
     Branches     3121     2853     -268     
   ==========================================
   - Hits        21559    18812    -2747     
   - Misses       8772    10256    +1484     
   - Partials      114      182      +68     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.00% <75.66%> (+0.27%)` | :arrow_up: |
   | #javascript | `?` | |
   | #python | `70.90% <ø> (-0.04%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `47.72% <ø> (-25.01%)` | :arrow_down: |
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <0.00%> (-55.67%)` | :arrow_down: |
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `7.40% <0.00%> (-51.86%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `50.64% <ø> (-4.49%)` | :arrow_down: |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (-5.56%)` | :arrow_down: |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (-17.65%)` | :arrow_down: |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (-66.67%)` | :arrow_down: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `51.96% <0.00%> (-31.62%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.33% <ø> (-42.67%)` | :arrow_down: |
   | ... and [239 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5b430ea...02a4e82](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `67.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   65.95%   -4.98%     
   ==========================================
     Files         183      593     +410     
     Lines       17847    30642   +12795     
     Branches        0     3200    +3200     
   ==========================================
   + Hits        12660    20211    +7551     
   - Misses       5187    10240    +5053     
   - Partials        0      191     +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.01% <67.44%> (?)` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...3106d17](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/80f834901805e5bc343617cecd5a78cc02476c96&el=desc) will **increase** coverage by `0.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.79%   70.93%   +0.13%     
   ==========================================
     Files         586      183     -403     
     Lines       30445    17847   -12598     
     Branches     3121        0    -3121     
   ==========================================
   - Hits        21555    12659    -8896     
   + Misses       8776     5188    -3588     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.93% <ø> (-0.01%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | | |
   | [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | | |
   | [...nd/src/dashboard/components/ColorComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yQ29tcG9uZW50UGFuZS5qc3g=) | | |
   | [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | | |
   | [...dashboard/util/logging/findTopLevelComponentIds.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZFRvcExldmVsQ29tcG9uZW50SWRzLmpz) | | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | | |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | | |
   | ... and [356 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [80f8349...43c6fa6](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5b430ead42c38692183a5471bf0b4bb4cb48eb20&el=desc) will **increase** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.81%   70.93%   +0.12%     
   ==========================================
     Files         586      183     -403     
     Lines       30445    17847   -12598     
     Branches     3121        0    -3121     
   ==========================================
   - Hits        21559    12660    -8899     
   + Misses       8772     5187    -3585     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | | |
   | [superset-frontend/src/components/RefreshLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVmcmVzaExhYmVsLmpzeA==) | | |
   | [...rontend/src/dashboard/containers/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEdyaWQuanN4) | | |
   | [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | | |
   | [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERldGFpbGVkQ29tcG9uZW50V2lkdGguanM=) | | |
   | [...rc/explore/components/controls/CheckboxControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9DaGVja2JveENvbnRyb2wuanN4) | | |
   | [...end/src/dashboard/util/findFirstParentContainer.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRGaXJzdFBhcmVudENvbnRhaW5lci5qcw==) | | |
   | [superset-frontend/src/components/CachedLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2FjaGVkTGFiZWwuanN4) | | |
   | ... and [355 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5b430ea...02a4e82](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45c8fcfd9296dc2291a1507208cf56a6d2466a43&el=desc) will **decrease** coverage by `4.84%`.
   > The diff coverage is `66.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.84%   66.00%   -4.85%     
   ==========================================
     Files         588      594       +6     
     Lines       30472    30652     +180     
     Branches     3153     3233      +80     
   ==========================================
   - Hits        21589    20231    -1358     
   - Misses       8769    10232    +1463     
   - Partials      114      189      +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.02% <66.27%> (-0.01%)` | :arrow_down: |
   | #python | `70.99% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [192 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [45c8fcf...f56d907](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] kristw commented on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
kristw commented on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631147717


   LGTM. 
   Will leave it to @etr2460.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   70.90%   -0.04%     
   ==========================================
     Files         183      183              
     Lines       17847    17847              
   ==========================================
   - Hits        12660    12654       -6     
   - Misses       5187     5193       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #python | `70.90% <ø> (-0.04%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.63% <0.00%> (-0.44%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...0b0a699](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6df5da1950f2c88a89b9a430d4e8a59006a36d3&el=desc) will **decrease** coverage by `11.71%`.
   > The diff coverage is `68.59%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9628       +/-   ##
   ===========================================
   - Coverage   70.78%   59.06%   -11.72%     
   ===========================================
     Files         587      410      -177     
     Lines       30456    12801    -17655     
     Branches     3121     3199       +78     
   ===========================================
   - Hits        21558     7561    -13997     
   + Misses       8784     5049     -3735     
   - Partials      114      191       +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.06% <68.59%> (+0.06%)` | :arrow_up: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.66% <ø> (-1.70%)` | :arrow_down: |
   | ... and [368 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [b6df5da...feb5cdb](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/34df11a61c79e8bbd1892825866714345f88748a&el=desc) will **decrease** coverage by `6.83%`.
   > The diff coverage is `79.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.89%   64.06%   -6.84%     
   ==========================================
     Files         585      539      -46     
     Lines       30427    29224    -1203     
     Branches     3152     2873     -279     
   ==========================================
   - Hits        21572    18723    -2849     
   - Misses       8744    10311    +1567     
   - Partials      111      190      +79     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.22% <79.88%> (-0.45%)` | :arrow_down: |
   | #javascript | `?` | |
   | #python | `70.96% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <ø> (-55.67%)` | :arrow_down: |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `74.07% <ø> (-22.23%)` | :arrow_down: |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (-5.56%)` | :arrow_down: |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (-17.65%)` | :arrow_down: |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (-66.67%)` | :arrow_down: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `48.03% <0.00%> (-35.56%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.47% <0.00%> (-42.53%)` | :arrow_down: |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `71.42% <ø> (-28.58%)` | :arrow_down: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | ... and [231 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [34df11a...a33b1ec](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `4.71%`.
   > The diff coverage is `65.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   71.02%   66.30%   -4.72%     
   ==========================================
     Files         583      589       +6     
     Lines       30615    30797     +182     
     Branches     3162     3241      +79     
   ==========================================
   - Hits        21745    20421    -1324     
   - Misses       8759    10189    +1430     
   - Partials      111      187      +76     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `71.27% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.66% <ø> (-1.70%)` | :arrow_down: |
   | ... and [188 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...3bfabac](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d167afb9499d7ce30c7ea763b19993af347dc23&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.72%   70.66%   -0.06%     
   ==========================================
     Files         584      182     -402     
     Lines       30382    17818   -12564     
     Branches     3112        0    -3112     
   ==========================================
   - Hits        21487    12591    -8896     
   + Misses       8781     5227    -3554     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.66% <ø> (-0.22%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
   | ... and [367 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5d167af...a5606a0](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6237cea95224903ea79aa82350dd7a175a120970&el=desc) will **decrease** coverage by `6.43%`.
   > The diff coverage is `75.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.79%   64.36%   -6.44%     
   ==========================================
     Files         586      541      -45     
     Lines       30445    29250    -1195     
     Branches     3121     2853     -268     
   ==========================================
   - Hits        21553    18826    -2727     
   - Misses       8777    10242    +1465     
   - Partials      115      182      +67     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.07% <75.66%> (+0.44%)` | :arrow_up: |
   | #javascript | `?` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <ø> (ø)` | |
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <0.00%> (-55.67%)` | :arrow_down: |
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `7.40% <0.00%> (-51.86%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `50.64% <ø> (-4.49%)` | :arrow_down: |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (-5.56%)` | :arrow_down: |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (-17.65%)` | :arrow_down: |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (-66.67%)` | :arrow_down: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `51.96% <0.00%> (-31.62%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.33% <ø> (-42.67%)` | :arrow_down: |
   | ... and [236 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [6237cea...69c63e7](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d167afb9499d7ce30c7ea763b19993af347dc23&el=desc) will **increase** coverage by `0.08%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.72%   70.80%   +0.08%     
   ==========================================
     Files         584      182     -402     
     Lines       30382    17824   -12558     
     Branches     3112        0    -3112     
   ==========================================
   - Hits        21487    12620    -8867     
   + Misses       8781     5204    -3577     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.80% <ø> (-0.08%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `87.80% <0.00%> (-0.77%)` | :arrow_down: |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.63% <0.00%> (-0.44%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.50% <0.00%> (-0.30%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.42% <0.00%> (-0.08%)` | :arrow_down: |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.37% <0.00%> (ø)` | |
   | ... and [366 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5d167af...8aff394](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425485429



##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/filter.js
##########
@@ -53,12 +53,11 @@ export default () =>
     });
 
     it('should apply filter', () => {
-      cy.wait(10);
-
-      cy.get('.Select-placeholder')
+      cy.get('.Select__control')
         .contains('Select [region]')
-        .click()
-        .next()
+        .click({ force: true })
+        // parent of placeholder component

Review comment:
       I think I was using a different selector when added that comment. Will delete.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5b430ead42c38692183a5471bf0b4bb4cb48eb20&el=desc) will **increase** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.81%   70.93%   +0.12%     
   ==========================================
     Files         586      183     -403     
     Lines       30445    17847   -12598     
     Branches     3121        0    -3121     
   ==========================================
   - Hits        21559    12660    -8899     
   + Misses       8772     5187    -3585     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | | |
   | [...tend/src/dashboard/containers/FilterIndicators.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlckluZGljYXRvcnMuanN4) | | |
   | [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyYWdEcm9wTWFuYWdlci5qcw==) | | |
   | [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | | |
   | [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | | |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | | |
   | ... and [355 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5b430ea...02a4e82](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `67.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   65.95%   -4.98%     
   ==========================================
     Files         183      593     +410     
     Lines       17847    30642   +12795     
     Branches        0     3200    +3200     
   ==========================================
   + Hits        12660    20211    +7551     
   - Misses       5187    10240    +5053     
   - Partials        0      191     +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.01% <67.44%> (?)` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...3106d17](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425506360



##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -0,0 +1,299 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { CSSProperties } from 'react';
+import { css, SerializedStyles } from '@emotion/core';
+import { supersetTheme } from '@superset-ui/style';
+import {
+  Styles,
+  Theme,
+  SelectComponentsConfig,
+  components as defaultComponents,
+} from 'react-select';
+import { colors as reactSelectColros } from 'react-select/src/theme';
+import { supersetColors } from 'src/components/styles';
+
+export const DEFAULT_CLASS_NAME = 'Select';
+export const DEFAULT_CLASS_NAME_PREFIX = 'Select';
+
+type RecursivePartial<T> = {

Review comment:
       I don't think it's used anywhere. Maybe refactor when it's needed? Unless pointed by someone, I don't think people would know it's available for use even if we have it in a global types file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d167afb9499d7ce30c7ea763b19993af347dc23&el=desc) will **increase** coverage by `0.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.72%   70.88%   +0.16%     
   ==========================================
     Files         584      182     -402     
     Lines       30382    17818   -12564     
     Branches     3112        0    -3112     
   ==========================================
   - Hits        21487    12630    -8857     
   + Misses       8781     5188    -3593     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.88% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
   | [superset-frontend/src/components/FaveStar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIuanN4) | | |
   | [...-frontend/src/components/IndeterminateCheckbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LmpzeA==) | | |
   | [superset-frontend/src/modules/AnnotationTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvQW5ub3RhdGlvblR5cGVzLmpz) | | |
   | [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | | |
   | [...end/src/visualizations/TimeTable/SparklineCell.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9TcGFya2xpbmVDZWxsLmpzeA==) | | |
   | [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | | |
   | ... and [359 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5d167af...a5606a0](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6df5da1950f2c88a89b9a430d4e8a59006a36d3&el=desc) will **decrease** coverage by `4.87%`.
   > The diff coverage is `68.59%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.78%   65.91%   -4.88%     
   ==========================================
     Files         587      593       +6     
     Lines       30456    30652     +196     
     Branches     3121     3199      +78     
   ==========================================
   - Hits        21558    20203    -1355     
   - Misses       8784    10258    +1474     
   - Partials      114      191      +77     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.06% <68.59%> (+0.06%)` | :arrow_up: |
   | #python | `70.81% <ø> (-0.12%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.66% <ø> (-1.70%)` | :arrow_down: |
   | ... and [196 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [b6df5da...feb5cdb](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.98%`.
   > The diff coverage is `67.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   65.95%   -4.99%     
   ==========================================
     Files         183      593     +410     
     Lines       17847    30642   +12795     
     Branches        0     3200    +3200     
   ==========================================
   + Hits        12660    20210    +7550     
   - Misses       5187    10241    +5054     
   - Partials        0      191     +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.01% <67.44%> (?)` | |
   | #python | `70.93% <ø> (-0.01%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...54ade59](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `88.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   71.02%   70.94%   -0.08%     
   ==========================================
     Files         583      589       +6     
     Lines       30615    30614       -1     
     Branches     3162     3241      +79     
   ==========================================
   - Hits        21745    21720      -25     
   - Misses       8759     8783      +24     
     Partials      111      111              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.02% <79.88%> (+0.46%)` | :arrow_up: |
   | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `70.95% <ø> (-0.32%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `88.18% <0.00%> (+4.60%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | ... and [91 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...5721a03](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `67.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   65.95%   -4.98%     
   ==========================================
     Files         183      593     +410     
     Lines       17847    30642   +12795     
     Branches        0     3200    +3200     
   ==========================================
   + Hits        12660    20211    +7551     
   - Misses       5187    10240    +5053     
   - Partials        0      191     +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.01% <67.44%> (?)` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...3106d17](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r421851735



##########
File path: superset-frontend/cypress-base/cypress/integration/explore/chart.test.js
##########
@@ -39,7 +38,6 @@ describe('No Results', () => {
           comparator: ['Fake State'],
           clause: 'WHERE',
           sqlExpression: null,
-          fromFormData: true,

Review comment:
       This is replaced with `AdhocFilter.isNew` and `AdhocMetric.isNew`. It was used to detect whether a adhoc metric/filter comes from stored metadata and to automatically open the edit popover when adding a new metric/filter.

##########
File path: superset-frontend/cypress-base/cypress/integration/explore/control.test.js
##########
@@ -211,17 +202,15 @@ describe('Advanced analytics', () => {
     cy.visitChartByName('Num Births Trend');
     cy.verifySliceSuccess({ waitAlias: '@postJson' });
 
-    cy.get('span')
-      .contains('Advanced Analytics')
-      .parent()
-      .siblings()
-      .first()
-      .click();
+    cy.get('.panel-title').contains('Advanced Analytics').click();
 
     cy.get('[data-test=time_compare]').within(() => {
-      cy.get('.Select-control').click({ force: true });
-      cy.get('input').type('364 days', { force: true });
-      cy.get('.VirtualizedSelectOption').trigger('mousedown').click();
+      cy.get('.Select__control').click();
+      cy.get('input[type=text]').type('28 days{enter}');

Review comment:
       Add one more option to account that this control allows for multiple values.

##########
File path: superset-frontend/package.json
##########
@@ -97,12 +97,15 @@
     "@superset-ui/translation": "^0.13.3",
     "@superset-ui/validator": "^0.13.3",
     "@types/classnames": "^2.2.9",
+    "@types/react-bootstrap": "^0.32.21",
     "@types/react-json-tree": "^0.6.11",
-    "@types/react-select": "^1.2.1",
+    "@types/react-select": "^3.0.12",
+    "@types/react-window": "^1.8.2",
     "@types/rison": "0.0.6",
     "@vx/responsive": "^0.0.195",
     "abortcontroller-polyfill": "^1.1.9",
     "aphrodite": "^2.3.1",
+    "array-move": "^2.2.1",

Review comment:
       Needed for `react-sortable-hoc`.

##########
File path: superset-frontend/spec/javascripts/components/OnPasteSelect_spec.jsx
##########
@@ -20,14 +20,16 @@
 import React from 'react';
 import sinon from 'sinon';
 import { shallow } from 'enzyme';
-import VirtualizedSelect from 'react-virtualized-select';
-import Select, { Creatable } from 'react-select';
-
-import OnPasteSelect from 'src/components/OnPasteSelect';
+import {
+  Select,
+  AsyncSelect,
+  OnPasteSelect,
+  CreatableSelect,
+} from 'src/components/Select';
 
 const defaultProps = {
   onChange: sinon.spy(),
-  multi: true,
+  isMulti: true,

Review comment:
       `OnPasteSelect` now uses `isMulti` to be consistent with `react-select`, but the `SelectControl` still uses `multi` to keep backward compatibility.

##########
File path: superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopoverSimpleTabContent_spec.jsx
##########
@@ -95,58 +95,50 @@ describe('AdhocFilterEditPopoverSimpleTabContent', () => {
       .instance()
       .onSubjectChange({ type: 'VARCHAR(255)', column_name: 'source' });
     expect(onChange.calledOnce).toBe(true);
-    expect(
-      onChange.lastCall.args[0].equals(
-        simpleAdhocFilter.duplicateWith({ subject: 'source' }),
-      ),
-    ).toBe(true);
+    expect(onChange.lastCall.args[0]).toEqual(
+      simpleAdhocFilter.duplicateWith({ subject: 'source' }),
+    );
   });
 
   it('may alter the clause in onSubjectChange if the old clause is not appropriate', () => {
     const { wrapper, onChange } = setup();
     wrapper.instance().onSubjectChange(sumValueAdhocMetric);
     expect(onChange.calledOnce).toBe(true);
-    expect(
-      onChange.lastCall.args[0].equals(
-        simpleAdhocFilter.duplicateWith({
-          subject: sumValueAdhocMetric.label,
-          clause: CLAUSES.HAVING,
-        }),
-      ),
-    ).toBe(true);
+    expect(onChange.lastCall.args[0]).toEqual(
+      simpleAdhocFilter.duplicateWith({
+        subject: sumValueAdhocMetric.label,
+        clause: CLAUSES.HAVING,
+      }),
+    );
   });
 
   it('will convert from individual comparator to array if the operator changes to multi', () => {
     const { wrapper, onChange } = setup();
-    wrapper.instance().onOperatorChange({ operator: 'in' });
+    wrapper.instance().onOperatorChange('in');

Review comment:
       Operator and aggregate options used in Select are now primitive strings instead of objects. Translations are handled by custom label renderer.

##########
File path: superset-frontend/spec/javascripts/explore/components/MetricsControl_spec.jsx
##########
@@ -297,7 +315,7 @@ describe('MetricsControl', () => {
         !!wrapper
           .instance()
           .selectFilterOption(
-            { aggregate_name: 'AVG', optionName: '_aggregate_AVG' },
+            { data: { aggregate_name: 'AVG', optionName: '_aggregate_AVG' } },

Review comment:
       This is because the signature of `react-select`'s `filterOption` changed.

##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -112,32 +110,34 @@ export const FilterInputs = ({
                 bsSize="small"
                 value={ft.operator}
                 placeholder={filter ? getDefaultFilterOperator(filter) : ''}
+                // @ts-ignore
                 onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
                   updateInternalFilter(i, {
                     operator: e.currentTarget.value,
                   });
                 }}
               >
-                {(filter.operators || []).map(({ label, value }: Select) => (
-                  <option key={label} value={value}>
-                    {label}
-                  </option>
-                ))}
+                {(filter.operators || []).map(
+                  ({ label, value }: SelectOption) => (
+                    <option key={label} value={value}>
+                      {label}
+                    </option>
+                  ),
+                )}
               </FormControl>
             </Col>
             <Col md={1} />
             <Col md={4}>
               {filter.input === 'select' && (
-                <VirtualizedSelect
+                <Select

Review comment:
       `src/components/Select` now transparently apply virtualization (via `react-window`) when the options list is too large.

##########
File path: superset-frontend/src/components/styles.ts
##########
@@ -0,0 +1,44 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+// Variables ported from "src/stylesheets/less/variables.less"
+// TODO: move to `@superset-ui/style`
+// Keep it here to make PRs easier for review.

Review comment:
       **Highlight this**

##########
File path: superset-frontend/src/dashboard/components/PropertiesModal.jsx
##########
@@ -238,14 +237,16 @@ class PropertiesModal extends React.PureComponent {
                 <label className="control-label" htmlFor="owners">
                   {t('Owners')}
                 </label>
-                <SelectAsync
+                <AsyncSelect
                   name="owners"
-                  multi
+                  isMulti
                   value={values.owners}
                   loadOptions={this.loadOwnerOptions}
+                  defaultOptions // load options on render
+                  cacheOptions
                   onChange={this.onOwnersChange}
                   disabled={!isDashboardLoaded}
-                  filterOption={() => true} // options are filtered at the api
+                  filterOption={null} // options are filtered at the api

Review comment:
       TODO: add test cases for this component (dashboard edit properties modal).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on issue #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618094574


   @nytai Feel free to continue your work on `StyledSelect`. I'll make sure to migrate the styles to `v3`. 
   
   
   cc @suddjian @rusackas


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6237cea95224903ea79aa82350dd7a175a120970&el=desc) will **decrease** coverage by `6.43%`.
   > The diff coverage is `75.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.79%   64.36%   -6.44%     
   ==========================================
     Files         586      541      -45     
     Lines       30445    29250    -1195     
     Branches     3121     2853     -268     
   ==========================================
   - Hits        21553    18826    -2727     
   - Misses       8777    10242    +1465     
   - Partials      115      182      +67     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.07% <75.66%> (+0.44%)` | :arrow_up: |
   | #javascript | `?` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <ø> (ø)` | |
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <0.00%> (-55.67%)` | :arrow_down: |
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `7.40% <0.00%> (-51.86%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `50.64% <ø> (-4.49%)` | :arrow_down: |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (-5.56%)` | :arrow_down: |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (-17.65%)` | :arrow_down: |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (-66.67%)` | :arrow_down: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `51.96% <0.00%> (-31.62%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.33% <ø> (-42.67%)` | :arrow_down: |
   | ... and [236 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [6237cea...69c63e7](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `88.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   71.02%   71.09%   +0.06%     
   ==========================================
     Files         583      589       +6     
     Lines       30615    30797     +182     
     Branches     3162     3241      +79     
   ==========================================
   + Hits        21745    21895     +150     
   - Misses       8759     8791      +32     
     Partials      111      111              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.02% <79.88%> (+0.46%)` | :arrow_up: |
   | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `71.20% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `88.18% <0.00%> (+4.60%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | ... and [59 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...5721a03](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on issue #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0

Posted by GitBox <gi...@apache.org>.
nytai commented on issue #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618100243


   @ktmud thanks for taking this on. It's no easy task. Let me know if I can help! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter commented on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `0.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   71.02%   70.79%   -0.24%     
   ==========================================
     Files         583      184     -399     
     Lines       30615    17868   -12747     
     Branches     3162        0    -3162     
   ==========================================
   - Hits        21745    12649    -9096     
   + Misses       8759     5219    -3540     
   + Partials      111        0     -111     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.79% <ø> (-0.48%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <ø> (-1.12%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
   | [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (-4.06%)` | :arrow_down: |
   | [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <0.00%> (-3.80%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...3bfabac](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `67.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   65.95%   -4.98%     
   ==========================================
     Files         183      593     +410     
     Lines       17847    30642   +12795     
     Branches        0     3200    +3200     
   ==========================================
   + Hits        12660    20211    +7551     
   - Misses       5187    10240    +5053     
   - Partials        0      191     +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.01% <67.44%> (?)` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [448 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...3106d17](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45c8fcfd9296dc2291a1507208cf56a6d2466a43&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.84%   70.83%   -0.02%     
   ==========================================
     Files         588      184     -404     
     Lines       30472    17861   -12611     
     Branches     3153        0    -3153     
   ==========================================
   - Hits        21589    12652    -8937     
   + Misses       8769     5209    -3560     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.83% <ø> (-0.23%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.77% <0.00%> (-2.36%)` | :arrow_down: |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <0.00%> (-1.03%)` | :arrow_down: |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.36%)` | :arrow_down: |
   | ... and [365 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [45c8fcf...f56d907](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6df5da1950f2c88a89b9a430d4e8a59006a36d3&el=desc) will **increase** coverage by `0.09%`.
   > The diff coverage is `89.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.78%   70.88%   +0.09%     
   ==========================================
     Files         587      593       +6     
     Lines       30456    30652     +196     
     Branches     3121     3199      +78     
   ==========================================
   + Hits        21558    21727     +169     
   - Misses       8784     8811      +27     
     Partials      114      114              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.16% <81.04%> (+0.43%)` | :arrow_up: |
   | #javascript | `59.06% <68.59%> (+0.06%)` | :arrow_up: |
   | #python | `70.92% <ø> (-0.02%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `88.18% <0.00%> (+4.60%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | ... and [55 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [b6df5da...feb5cdb](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6237cea95224903ea79aa82350dd7a175a120970&el=desc) will **decrease** coverage by `6.43%`.
   > The diff coverage is `75.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.79%   64.36%   -6.44%     
   ==========================================
     Files         586      541      -45     
     Lines       30445    29250    -1195     
     Branches     3121     2853     -268     
   ==========================================
   - Hits        21553    18826    -2727     
   - Misses       8777    10242    +1465     
   - Partials      115      182      +67     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.07% <75.66%> (+0.44%)` | :arrow_up: |
   | #javascript | `?` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <ø> (ø)` | |
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <0.00%> (-55.67%)` | :arrow_down: |
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `7.40% <0.00%> (-51.86%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `50.64% <ø> (-4.49%)` | :arrow_down: |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (-5.56%)` | :arrow_down: |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (-17.65%)` | :arrow_down: |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (-66.67%)` | :arrow_down: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `51.96% <0.00%> (-31.62%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.33% <ø> (-42.67%)` | :arrow_down: |
   | ... and [236 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [6237cea...69c63e7](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425507511



##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -0,0 +1,299 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { CSSProperties } from 'react';
+import { css, SerializedStyles } from '@emotion/core';
+import { supersetTheme } from '@superset-ui/style';
+import {
+  Styles,
+  Theme,
+  SelectComponentsConfig,
+  components as defaultComponents,
+} from 'react-select';
+import { colors as reactSelectColros } from 'react-select/src/theme';
+import { supersetColors } from 'src/components/styles';
+
+export const DEFAULT_CLASS_NAME = 'Select';
+export const DEFAULT_CLASS_NAME_PREFIX = 'Select';
+
+type RecursivePartial<T> = {
+  [P in keyof T]?: RecursivePartial<T[P]>;
+};
+
+export type ThemeConfig = {
+  borderRadius: number;
+  // z-index for menu dropdown
+  // (the same as `@z-index-above-dashboard-charts + 1` in variables.less)
+  zIndex: number;
+  colors: {
+    // add known colors
+    [key in keyof typeof reactSelectColros]: string;
+  } &
+    {
+      [key in keyof typeof supersetColors]: string;
+    } & {
+      [key: string]: string; // any other colors
+    };
+  spacing: Theme['spacing'] & {
+    // line height and font size must be pixels for easier computation
+    // of option item height in WindowedMenuList
+    lineHeight: number;
+    fontSize: number;
+    // other relative size must be string
+    minWidth: string;
+  };
+};
+
+export type PartialThemeConfig = RecursivePartial<ThemeConfig>;
+
+export const DEFAULT_THEME: PartialThemeConfig = {
+  borderRadius: parseInt(supersetTheme.borderRadius, 10),
+  zIndex: 11,

Review comment:
       Yes, this number `11` was obtained from `variables.less` (there is a note in the type definition above). I don't know how to make a variable accessible to both less and styled components, so I just added the CSS variable name for reference. In the future, we might want to refactor all these to real CSS variables.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425488309



##########
File path: superset-frontend/src/components/AsyncSelect.jsx
##########
@@ -18,7 +18,8 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
-import Select from 'react-select';
+// TODO: refactor this with `import { AsyncSelect } from src/components/Select`

Review comment:
       This component handles its own async logics, which doesn't seem necessary and is kind of confusing (we probably don't want to two ways of doing AsyncSelect).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **increase** coverage by `0.10%`.
   > The diff coverage is `88.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   71.02%   71.13%   +0.10%     
   ==========================================
     Files         583      589       +6     
     Lines       30615    30797     +182     
     Branches     3162     3241      +79     
   ==========================================
   + Hits        21745    21906     +161     
   - Misses       8759     8780      +21     
     Partials      111      111              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.01% <79.88%> (+0.46%)` | :arrow_up: |
   | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `71.27% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `88.18% <0.00%> (+4.60%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | ... and [57 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...3bfabac](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6237cea95224903ea79aa82350dd7a175a120970&el=desc) will **decrease** coverage by `6.43%`.
   > The diff coverage is `75.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.79%   64.36%   -6.44%     
   ==========================================
     Files         586      541      -45     
     Lines       30445    29250    -1195     
     Branches     3121     2853     -268     
   ==========================================
   - Hits        21553    18826    -2727     
   - Misses       8777    10242    +1465     
   - Partials      115      182      +67     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.07% <75.66%> (+0.44%)` | :arrow_up: |
   | #javascript | `?` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <ø> (ø)` | |
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <0.00%> (-55.67%)` | :arrow_down: |
   | [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `7.40% <0.00%> (-51.86%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `50.64% <ø> (-4.49%)` | :arrow_down: |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (-5.56%)` | :arrow_down: |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (-17.65%)` | :arrow_down: |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (-66.67%)` | :arrow_down: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `51.96% <0.00%> (-31.62%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.33% <ø> (-42.67%)` | :arrow_down: |
   | ... and [236 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [6237cea...69c63e7](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r424642916



##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -67,9 +63,10 @@ export const FilterMenu = ({
           <MenuItem
             key={ft.id}
             eventKey={ft}
-            onSelect={(fltr: typeof ft) =>
-              setInternalFilters([...internalFilters, fltr])
-            }
+            // @ts-ignore

Review comment:
       > Type 'MouseEvent<{}, MouseEvent>' is missing the following properties from type '{ Header: string; id: string; value: undefined; }': Header, id, value
   
   
   Inconsistent callback function signature. onSelect in MenuItem expects an event, but the callback seems to be expecting the fltr type (bad variable name btw).
   
   Didn't want to change the actual code and didn't dig too deep into how to make it proper, since this file is going to be deprecated anyway (@nytai is working on a new ListView).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a95c52d61efc4940348319456eab87eb531c936&el=desc) will **decrease** coverage by `4.91%`.
   > The diff coverage is `65.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   71.01%   66.10%   -4.92%     
   ==========================================
     Files         586      592       +6     
     Lines       30635    30634       -1     
     Branches     3159     3238      +79     
   ==========================================
   - Hits        21756    20250    -1506     
   - Misses       8768    10197    +1429     
   - Partials      111      187      +76     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.22% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `71.01% <ø> (-0.26%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [224 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [7a95c52...8948497](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **increase** coverage by `0.10%`.
   > The diff coverage is `88.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   71.02%   71.13%   +0.10%     
   ==========================================
     Files         583      589       +6     
     Lines       30615    30797     +182     
     Branches     3162     3241      +79     
   ==========================================
   + Hits        21745    21907     +162     
   - Misses       8759     8779      +20     
     Partials      111      111              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.02% <79.88%> (+0.46%)` | :arrow_up: |
   | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `71.27% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `88.18% <0.00%> (+4.60%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | ... and [56 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...5721a03](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `0.58%`.
   > The diff coverage is `88.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   71.02%   70.43%   -0.59%     
   ==========================================
     Files         583      405     -178     
     Lines       30615    12746   -17869     
     Branches     3162     3241      +79     
   ==========================================
   - Hits        21745     8978   -12767     
   + Misses       8759     3650    -5109     
   - Partials      111      118       +7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.17% <79.88%> (-0.38%)` | :arrow_down: |
   | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `88.18% <0.00%> (+4.60%)` | :arrow_up: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | ... and [242 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...5721a03](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425494501



##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -37,13 +44,21 @@ interface SelectFilterProps extends BaseFilter {
 
 const FilterContainer = styled.div`
   display: inline-flex;
-  margin-right: 8px;
+  margin-right: 1.2em;

Review comment:
       Personal preference. When the spacing should scale according to font sizes, it makes more sense to use `em`s.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   70.82%   -0.11%     
   ==========================================
     Files         183      183              
     Lines       17847    17847              
   ==========================================
   - Hits        12660    12641      -19     
   - Misses       5187     5206      +19     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #python | `70.82% <ø> (-0.11%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `63.33% <0.00%> (-10.01%)` | :arrow_down: |
   | [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.63% <0.00%> (-1.69%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.63% <0.00%> (-0.44%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.50% <0.00%> (-0.30%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...0b0a699](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425488309



##########
File path: superset-frontend/src/components/AsyncSelect.jsx
##########
@@ -18,7 +18,8 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
-import Select from 'react-select';
+// TODO: refactor this with `import { AsyncSelect } from src/components/Select`

Review comment:
       This component handles its own async logics, which doesn't seem necessary and is kind of confusing (we probably don't want two ways of doing AsyncSelect).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425509615



##########
File path: superset-frontend/src/explore/AdhocFilter.js
##########
@@ -94,7 +91,7 @@ export default class AdhocFilter {
       this.comparator = null;
     }
     this.isExtra = !!adhocFilter.isExtra;
-    this.fromFormData = !!adhocFilter.filterOptionName;
+    this.isNew = adhocFilter.isNew || false;

Review comment:
       I guess both works.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] nytai commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r424714108



##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -67,9 +63,10 @@ export const FilterMenu = ({
           <MenuItem
             key={ft.id}
             eventKey={ft}
-            onSelect={(fltr: typeof ft) =>
-              setInternalFilters([...internalFilters, fltr])
-            }
+            // @ts-ignore

Review comment:
       Yes, this is old code that's going to be killed soon. I think react-bootstrap was missing proper typings when this was being implemented so some type is probably being overridden incorrectly.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/34df11a61c79e8bbd1892825866714345f88748a&el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.89%   70.79%   -0.10%     
   ==========================================
     Files         585      184     -401     
     Lines       30427    17863   -12564     
     Branches     3152        0    -3152     
   ==========================================
   - Hits        21572    12647    -8925     
   + Misses       8744     5216    -3528     
   + Partials      111        0     -111     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.79% <ø> (-0.23%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <ø> (-0.23%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.77% <0.00%> (-2.36%)` | :arrow_down: |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <0.00%> (-1.03%)` | :arrow_down: |
   | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [34df11a...a33b1ec](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `11.74%`.
   > The diff coverage is `65.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9628       +/-   ##
   ===========================================
   - Coverage   71.02%   59.28%   -11.75%     
   ===========================================
     Files         583      405      -178     
     Lines       30615    12746    -17869     
     Branches     3162     3241       +79     
   ===========================================
   - Hits        21745     7556    -14189     
   + Misses       8759     5003     -3756     
   - Partials      111      187       +76     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.66% <ø> (-1.70%)` | :arrow_down: |
   | ... and [366 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...5721a03](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `6.62%`.
   > The diff coverage is `80.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   64.31%   -6.63%     
   ==========================================
     Files         183      541     +358     
     Lines       17847    29247   +11400     
     Branches        0     2852    +2852     
   ==========================================
   + Hits        12660    18810    +6150     
   - Misses       5187    10255    +5068     
   - Partials        0      182     +182     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.00% <80.50%> (?)` | |
   | #python | `70.90% <ø> (-0.04%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `51.96% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.47% <0.00%> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `71.42% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | [...components/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU3FsVGFiQ29udGVudC5qc3g=) | `91.17% <ø> (ø)` | |
   | ... and [392 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...0b0a699](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r421899928



##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.less
##########
@@ -18,35 +18,10 @@
  */
 @import '../../../stylesheets/less/variables.less';
 
-.select2-highlighted > .filter_box {
-  background-color: transparent;
-  border: 1px superset @darkest;
-}

Review comment:
       `select2` is obviously not used anymore.

##########
File path: superset-frontend/src/explore/main.less
##########
@@ -106,14 +98,16 @@
   float: left;
   padding-right: 3px;
 
-  .Select-control {
+  .dropdown {
     display: flex;
-
-    .Select-arrow-zone {
-      width: auto;
-      position: absolute;
-      right: 0;
-      top: 12px;
+    button {
+      padding-right: 20px;
+      .caret {
+        width: auto;
+        position: absolute;
+        right: 5px;
+        top: 6px;
+      }

Review comment:
       This is for fixing some styles in date selector:
   
   ### Before
   
   ![image](https://user-images.githubusercontent.com/335541/81363494-5133cf00-9098-11ea-8d98-1f711b1aef55.png)
   
   
   ### After
   
   ![image](https://user-images.githubusercontent.com/335541/81363549-745e7e80-9098-11ea-8ca4-9eb5393b0532.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5b430ead42c38692183a5471bf0b4bb4cb48eb20&el=desc) will **increase** coverage by `0.12%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.81%   70.93%   +0.12%     
   ==========================================
     Files         586      183     -403     
     Lines       30445    17847   -12598     
     Branches     3121        0    -3121     
   ==========================================
   - Hits        21559    12660    -8899     
   + Misses       8772     5187    -3585     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.93% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | | |
   | [...et-frontend/src/explore/controlPanels/TimePivot.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9UaW1lUGl2b3QuanM=) | | |
   | [...nd/src/dashboard/components/ColorComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yQ29tcG9uZW50UGFuZS5qc3g=) | | |
   | [...erset-frontend/src/messageToasts/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcmVkdWNlcnMvaW5kZXguanM=) | | |
   | [...dashboard/util/logging/findTopLevelComponentIds.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2xvZ2dpbmcvZmluZFRvcExldmVsQ29tcG9uZW50SWRzLmpz) | | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | | |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | | |
   | [superset-frontend/src/CRUD/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvdXRpbHMuanM=) | | |
   | ... and [355 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5b430ea...02a4e82](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/34df11a61c79e8bbd1892825866714345f88748a&el=desc) will **decrease** coverage by `0.09%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.89%   70.79%   -0.10%     
   ==========================================
     Files         585      184     -401     
     Lines       30427    17863   -12564     
     Branches     3152        0    -3152     
   ==========================================
   - Hits        21572    12647    -8925     
   + Misses       8744     5216    -3528     
   + Partials      111        0     -111     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.79% <ø> (-0.23%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <ø> (-0.23%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.77% <0.00%> (-2.36%)` | :arrow_down: |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <0.00%> (-1.03%)` | :arrow_down: |
   | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [34df11a...b8ba052](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d167afb9499d7ce30c7ea763b19993af347dc23&el=desc) will **increase** coverage by `0.15%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.72%   70.87%   +0.15%     
   ==========================================
     Files         584      182     -402     
     Lines       30382    17824   -12558     
     Branches     3112        0    -3112     
   ==========================================
   - Hits        21487    12633    -8854     
   + Misses       8781     5191    -3590     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.87% <ø> (-0.01%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.42% <0.00%> (-0.08%)` | :arrow_down: |
   | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.37% <0.00%> (ø)` | |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | | |
   | [superset-frontend/src/modules/AnnotationTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvQW5ub3RhdGlvblR5cGVzLmpz) | | |
   | [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | | |
   | [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | | |
   | [...et-frontend/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29uZmlybVN0YXR1c0NoYW5nZS50c3g=) | | |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | | |
   | ... and [360 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5d167af...8aff394](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45c8fcfd9296dc2291a1507208cf56a6d2466a43&el=desc) will **increase** coverage by `0.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.84%   70.99%   +0.14%     
   ==========================================
     Files         588      184     -404     
     Lines       30472    17861   -12611     
     Branches     3153        0    -3153     
   ==========================================
   - Hits        21589    12681    -8908     
   + Misses       8769     5180    -3589     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.99% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-0.89%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <0.00%> (-0.23%)` | :arrow_down: |
   | [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | | |
   | [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | | |
   | [...et-frontend/src/dashboard/actions/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEluZm8uanM=) | | |
   | [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | | |
   | ... and [358 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [45c8fcf...f56d907](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `11.92%`.
   > The diff coverage is `67.44%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9628       +/-   ##
   ===========================================
   - Coverage   70.93%   59.01%   -11.93%     
   ===========================================
     Files         183      410      +227     
     Lines       17847    12795     -5052     
     Branches        0     3200     +3200     
   ===========================================
   - Hits        12660     7551     -5109     
   + Misses       5187     5053      -134     
   - Partials        0      191      +191     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.01% <67.44%> (?)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | |
   | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `40.00% <ø> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | |
   | ... and [627 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...54ade59](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r424716562



##########
File path: superset-frontend/src/components/ColumnOption.jsx
##########
@@ -42,28 +42,28 @@ export default function ColumnOption({ column, showType }) {
   }
 
   return (
-    <span>
+    <div className="column-option">

Review comment:
       Why is this a div instead of a span now? I don't see anything in the css that would make this inline

##########
File path: superset-frontend/src/components/AsyncSelect.jsx
##########
@@ -18,7 +18,8 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
-import Select from 'react-select';
+// TODO: refactor this with `import { AsyncSelect } from src/components/Select`

Review comment:
       Does this mean this component is no longer actually Async?

##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -0,0 +1,299 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { CSSProperties } from 'react';
+import { css, SerializedStyles } from '@emotion/core';
+import { supersetTheme } from '@superset-ui/style';
+import {
+  Styles,
+  Theme,
+  SelectComponentsConfig,
+  components as defaultComponents,
+} from 'react-select';
+import { colors as reactSelectColros } from 'react-select/src/theme';
+import { supersetColors } from 'src/components/styles';
+
+export const DEFAULT_CLASS_NAME = 'Select';
+export const DEFAULT_CLASS_NAME_PREFIX = 'Select';
+
+type RecursivePartial<T> = {
+  [P in keyof T]?: RecursivePartial<T[P]>;
+};
+
+export type ThemeConfig = {
+  borderRadius: number;
+  // z-index for menu dropdown
+  // (the same as `@z-index-above-dashboard-charts + 1` in variables.less)
+  zIndex: number;
+  colors: {
+    // add known colors
+    [key in keyof typeof reactSelectColros]: string;
+  } &
+    {
+      [key in keyof typeof supersetColors]: string;
+    } & {
+      [key: string]: string; // any other colors
+    };
+  spacing: Theme['spacing'] & {
+    // line height and font size must be pixels for easier computation
+    // of option item height in WindowedMenuList
+    lineHeight: number;
+    fontSize: number;
+    // other relative size must be string
+    minWidth: string;
+  };
+};
+
+export type PartialThemeConfig = RecursivePartial<ThemeConfig>;
+
+export const DEFAULT_THEME: PartialThemeConfig = {
+  borderRadius: parseInt(supersetTheme.borderRadius, 10),
+  zIndex: 11,

Review comment:
       we have zIndex constants defined already, can we reuse them here? Or move them into someplace useable by both LESS and Styled Components
   
   https://github.com/apache/incubator-superset/blob/291306392443a5a0d0e2ee0cc4a95d37c56d4589/superset-frontend/stylesheets/less/cosmo/variables.less#L270

##########
File path: superset-frontend/src/explore/AdhocFilter.js
##########
@@ -94,7 +91,7 @@ export default class AdhocFilter {
       this.comparator = null;
     }
     this.isExtra = !!adhocFilter.isExtra;
-    this.fromFormData = !!adhocFilter.filterOptionName;
+    this.isNew = adhocFilter.isNew || false;

Review comment:
       why not `!!adhocFilter.isNew`?

##########
File path: superset-frontend/src/components/Select/WindowedSelect/WindowedMenuList.tsx
##########
@@ -0,0 +1,155 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, {
+  useRef,
+  useEffect,
+  Component,
+  FunctionComponent,
+  RefObject,
+} from 'react';
+import {
+  ListChildComponentProps,
+  FixedSizeList as WindowedList,
+} from 'react-window';
+import {
+  OptionTypeBase,
+  OptionProps,
+  MenuListComponentProps,
+} from 'react-select';
+import { ThemeConfig } from '../styles';
+
+export type WindowedMenuListProps = {
+  selectProps: {
+    windowListRef?: RefObject<WindowedList>;
+    optionHeight?: number;
+  };
+};
+
+/**
+ * MenuListComponentProps should always have `children` elements, as guaranteed
+ * by https://github.com/JedWatson/react-select/blob/32ad5c040bdd96cd1ca71010c2558842d684629c/packages/react-select/src/Select.js#L1686-L1719
+ *
+ * `children` may also be `Component<NoticeProps<OptionType>>` if options are not
+ * provided (e.g., when async list is still loading, or no results), but that's
+ * not possible because this MenuList will only be rendered when
+ * optionsLength > windowThreshold.
+ *
+ * If may also be `Component<GroupProps<OptionType>>[]` but we are not supporting
+ * grouped options just yet.
+ */
+export type MenuListProps<
+  OptionType extends OptionTypeBase
+> = MenuListComponentProps<OptionType> & {
+  children: Component<OptionProps<OptionType>>[];
+  // theme is not present with built-in @types/react-select, but is actually
+  // available via CommonProps.
+  theme?: ThemeConfig;
+  className?: string;
+} & WindowedMenuListProps;
+
+/**
+ * Get the index of the last selected option.
+ */
+function getLastSelected(children: Component<any>[]) {
+  return Array.isArray(children)
+    ? Math.max(
+        children.findIndex(
+          ({ props: { isFocused = false } = {} }) => isFocused,
+        ),
+        0,
+      )
+    : -1;
+}
+
+/**
+ * Calculate probable option height as set in theme configs
+ */
+function detectHeight({ spacing: { baseUnit, lineHeight } }: ThemeConfig) {
+  return baseUnit * 4 + lineHeight;
+}
+
+export default function WindowedMenuList<OptionType extends OptionTypeBase>({
+  children,
+  ...props
+}: MenuListProps<OptionType>) {
+  const {
+    maxHeight,
+    selectProps,
+    theme,
+    getStyles,
+    cx,
+    innerRef,
+    isMulti,
+    className,
+  } = props;
+  const {
+    // Expose react-window VariableSizeList instance and HTML elements
+    windowListRef = useRef(null),
+    windowListInnerRef,
+  } = selectProps;
+
+  // try get default option height from theme configs
+  let optionHeight = selectProps.optionHeight;
+  if (!optionHeight) {
+    optionHeight = theme ? detectHeight(theme) : 30;

Review comment:
       let's make 30 a constant here

##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/filter.js
##########
@@ -53,12 +53,11 @@ export default () =>
     });
 
     it('should apply filter', () => {
-      cy.wait(10);
-
-      cy.get('.Select-placeholder')
+      cy.get('.Select__control')
         .contains('Select [region]')
-        .click()
-        .next()
+        .click({ force: true })
+        // parent of placeholder component

Review comment:
       I feel like this comment isn't necessary because `.parent()` is pretty obvious what it does, but up to you

##########
File path: superset-frontend/src/components/Select/SupersetStyledSelect.tsx
##########
@@ -0,0 +1,301 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { SyntheticEvent, MutableRefObject } from 'react';
+import { merge } from 'lodash';
+import BasicSelect, {
+  OptionTypeBase,
+  MultiValueProps,
+  FormatOptionLabelMeta,
+  ValueType,
+  SelectComponentsConfig,
+  components as defaultComponents,
+  createFilter,
+} from 'react-select';
+import Async from 'react-select/async';
+import Creatable from 'react-select/creatable';
+import AsyncCreatable from 'react-select/async-creatable';
+
+import { SelectComponents } from 'react-select/src/components';
+import {
+  SortableContainer,
+  SortableElement,
+  SortableContainerProps,
+} from 'react-sortable-hoc';
+import arrayMove from 'array-move';
+import {
+  WindowedSelectComponentType,
+  WindowedSelectProps,
+  WindowedSelect,
+  WindowedAsyncSelect,
+  WindowedCreatableSelect,
+  WindowedAsyncCreatableSelect,
+} from './WindowedSelect';
+import {
+  DEFAULT_CLASS_NAME,
+  DEFAULT_CLASS_NAME_PREFIX,
+  DEFAULT_STYLES,
+  DEFAULT_THEME,
+  DEFAULT_COMPONENTS,
+  VALUE_LABELED_STYLES,
+  PartialThemeConfig,
+  PartialStylesConfig,
+} from './styles';
+import { findValue } from './utils';
+
+const DEFAULT_WINDOW_THRESHOLD = 100;
+
+type AnyReactSelect<OptionType extends OptionTypeBase> =
+  | BasicSelect<OptionType>
+  | Async<OptionType>
+  | Creatable<OptionType>
+  | AsyncCreatable<OptionType>;
+
+export type SupersetStyledSelectProps<
+  OptionType extends OptionTypeBase,
+  T extends WindowedSelectProps<OptionType> = WindowedSelectProps<OptionType>
+> = T & {
+  // additional props for easier usage or backward compatibility
+  labelKey?: string;
+  valueKey?: string;
+  multi?: boolean;
+  clearable?: boolean;
+  sortable?: boolean;
+  ignoreAccents?: boolean;
+  creatable?: boolean;
+  selectRef?:
+    | React.RefCallback<AnyReactSelect<OptionType>>
+    | MutableRefObject<AnyReactSelect<OptionType>>;
+  getInputValue?: (selectBalue: ValueType<OptionType>) => string | undefined;
+  optionRenderer?: (option: OptionType) => React.ReactNode;
+  valueRenderer?: (option: OptionType) => React.ReactNode;
+  valueRenderedAsLabel?: boolean;
+  // callback for paste event
+  onPaste?: (e: SyntheticEvent) => void;
+  // for simplier theme overrides
+  themeConfig?: PartialThemeConfig;
+  stylesConfig?: PartialStylesConfig;
+};
+
+function styled<
+  OptionType extends OptionTypeBase,
+  SelectComponentType extends WindowedSelectComponentType<
+    OptionType
+  > = WindowedSelectComponentType<OptionType>
+>(SelectComponent: SelectComponentType) {
+  type SelectProps = SupersetStyledSelectProps<OptionType>;
+  type Components = SelectComponents<OptionType>;
+
+  const SortableSelectComponent = SortableContainer(SelectComponent, {
+    withRef: true,
+  });
+
+  // default components for the given OptionType
+  const supersetDefaultComponents: SelectComponentsConfig<OptionType> = DEFAULT_COMPONENTS;
+
+  const getSortableMultiValue = (MultiValue: Components['MultiValue']) => {
+    return SortableElement((props: MultiValueProps<OptionType>) => {
+      const onMouseDown = (e: SyntheticEvent) => {
+        e.preventDefault();
+        e.stopPropagation();
+      };
+      const innerProps = { onMouseDown };
+      return <MultiValue {...props} innerProps={innerProps} />;
+    });
+  };
+
+  /**
+   * Superset styled `Select` component. Apply Superset themed stylesheets and
+   * consolidate props API for backward compatibility with react-select v1.
+   */
+  function StyledSelect(selectProps: SelectProps) {
+    let stateManager: AnyReactSelect<OptionType>; // reference to react-select StateManager
+    const {
+      selectRef,
+      options,
+      value: value_,
+      className = DEFAULT_CLASS_NAME,
+      classNamePrefix = DEFAULT_CLASS_NAME_PREFIX,
+      themeConfig,
+      stylesConfig = {},
+

Review comment:
       style nits, but all this white space inside the object destructure is a bit hard to read. I think with the comments we could remove all the white space here and there would still be a good separation of categories. up to you though

##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -37,13 +44,21 @@ interface SelectFilterProps extends BaseFilter {
 
 const FilterContainer = styled.div`
   display: inline-flex;
-  margin-right: 8px;
+  margin-right: 1.2em;

Review comment:
       Are we using `em`s instead of `px`s now? What led to this change?

##########
File path: superset-frontend/src/components/Select/WindowedSelect/WindowedMenuList.tsx
##########
@@ -0,0 +1,155 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, {
+  useRef,
+  useEffect,
+  Component,
+  FunctionComponent,
+  RefObject,
+} from 'react';
+import {
+  ListChildComponentProps,
+  FixedSizeList as WindowedList,
+} from 'react-window';
+import {
+  OptionTypeBase,
+  OptionProps,
+  MenuListComponentProps,
+} from 'react-select';
+import { ThemeConfig } from '../styles';
+
+export type WindowedMenuListProps = {
+  selectProps: {
+    windowListRef?: RefObject<WindowedList>;
+    optionHeight?: number;
+  };
+};
+
+/**
+ * MenuListComponentProps should always have `children` elements, as guaranteed
+ * by https://github.com/JedWatson/react-select/blob/32ad5c040bdd96cd1ca71010c2558842d684629c/packages/react-select/src/Select.js#L1686-L1719
+ *
+ * `children` may also be `Component<NoticeProps<OptionType>>` if options are not
+ * provided (e.g., when async list is still loading, or no results), but that's
+ * not possible because this MenuList will only be rendered when
+ * optionsLength > windowThreshold.
+ *
+ * If may also be `Component<GroupProps<OptionType>>[]` but we are not supporting
+ * grouped options just yet.
+ */
+export type MenuListProps<
+  OptionType extends OptionTypeBase
+> = MenuListComponentProps<OptionType> & {
+  children: Component<OptionProps<OptionType>>[];
+  // theme is not present with built-in @types/react-select, but is actually
+  // available via CommonProps.
+  theme?: ThemeConfig;
+  className?: string;
+} & WindowedMenuListProps;
+
+/**
+ * Get the index of the last selected option.
+ */
+function getLastSelected(children: Component<any>[]) {
+  return Array.isArray(children)
+    ? Math.max(
+        children.findIndex(
+          ({ props: { isFocused = false } = {} }) => isFocused,
+        ),
+        0,
+      )
+    : -1;
+}
+
+/**
+ * Calculate probable option height as set in theme configs
+ */
+function detectHeight({ spacing: { baseUnit, lineHeight } }: ThemeConfig) {
+  return baseUnit * 4 + lineHeight;

Review comment:
       what does 4 represent? can we make it a constant?

##########
File path: superset-frontend/src/explore/constants.js
##########
@@ -53,10 +55,10 @@ export const HAVING_OPERATORS = [
   OPERATORS['>='],
   OPERATORS['<='],
 ];
-export const MULTI_OPERATORS = [OPERATORS.in, OPERATORS['not in']];
+export const MULTI_OPERATORS = new Set([OPERATORS.in, OPERATORS['not in']]);

Review comment:
       not changed here, but I believe @villebro standardized the operators to be `IN` and `NOT IN`. Perhaps that change should be made?

##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -0,0 +1,299 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { CSSProperties } from 'react';
+import { css, SerializedStyles } from '@emotion/core';
+import { supersetTheme } from '@superset-ui/style';
+import {
+  Styles,
+  Theme,
+  SelectComponentsConfig,
+  components as defaultComponents,
+} from 'react-select';
+import { colors as reactSelectColros } from 'react-select/src/theme';
+import { supersetColors } from 'src/components/styles';
+
+export const DEFAULT_CLASS_NAME = 'Select';
+export const DEFAULT_CLASS_NAME_PREFIX = 'Select';
+
+type RecursivePartial<T> = {

Review comment:
       this seems like it could be useful in a global types file. does one exist yet? if not should we make one?

##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -0,0 +1,299 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { CSSProperties } from 'react';
+import { css, SerializedStyles } from '@emotion/core';
+import { supersetTheme } from '@superset-ui/style';
+import {
+  Styles,
+  Theme,
+  SelectComponentsConfig,
+  components as defaultComponents,
+} from 'react-select';
+import { colors as reactSelectColros } from 'react-select/src/theme';
+import { supersetColors } from 'src/components/styles';
+
+export const DEFAULT_CLASS_NAME = 'Select';
+export const DEFAULT_CLASS_NAME_PREFIX = 'Select';
+
+type RecursivePartial<T> = {
+  [P in keyof T]?: RecursivePartial<T[P]>;
+};
+
+export type ThemeConfig = {
+  borderRadius: number;
+  // z-index for menu dropdown
+  // (the same as `@z-index-above-dashboard-charts + 1` in variables.less)
+  zIndex: number;
+  colors: {
+    // add known colors
+    [key in keyof typeof reactSelectColros]: string;
+  } &
+    {
+      [key in keyof typeof supersetColors]: string;
+    } & {
+      [key: string]: string; // any other colors
+    };
+  spacing: Theme['spacing'] & {
+    // line height and font size must be pixels for easier computation
+    // of option item height in WindowedMenuList
+    lineHeight: number;
+    fontSize: number;
+    // other relative size must be string
+    minWidth: string;
+  };
+};
+
+export type PartialThemeConfig = RecursivePartial<ThemeConfig>;
+
+export const DEFAULT_THEME: PartialThemeConfig = {
+  borderRadius: parseInt(supersetTheme.borderRadius, 10),
+  zIndex: 11,
+  colors: {
+    ...supersetColors,
+    dangerLight: supersetColors.warning,
+  },
+  spacing: {
+    baseUnit: 3,
+    menuGutter: 0,
+    controlHeight: 28,
+    lineHeight: 19,
+    fontSize: 14,
+    minWidth: '7.5em', // just enough to display 'No options'
+  },
+};
+
+// let styles accept serialized CSS, too
+type CSSStyles = CSSProperties | SerializedStyles;
+type styleFnWithSerializedStyles = (
+  base: CSSProperties,
+  state: any,
+) => CSSStyles | CSSStyles[];
+
+export type StylesConfig = {
+  [key in keyof Styles]: styleFnWithSerializedStyles;
+};
+export type PartialStylesConfig = Partial<StylesConfig>;
+
+// Please install "vscode-styled-components" to get properly syntax highlight

Review comment:
       let's remove this comment and add it to CONTRIBUTING.md




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425493528



##########
File path: superset-frontend/src/components/ColumnOption.jsx
##########
@@ -42,28 +42,28 @@ export default function ColumnOption({ column, showType }) {
   }
 
   return (
-    <span>
+    <div className="column-option">

Review comment:
       I tend to prefer `div` unless there is a specific need to make something inline. This component doesn't seem to need inline.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425504781



##########
File path: superset-frontend/src/components/Select/WindowedSelect/WindowedMenuList.tsx
##########
@@ -0,0 +1,155 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, {
+  useRef,
+  useEffect,
+  Component,
+  FunctionComponent,
+  RefObject,
+} from 'react';
+import {
+  ListChildComponentProps,
+  FixedSizeList as WindowedList,
+} from 'react-window';
+import {
+  OptionTypeBase,
+  OptionProps,
+  MenuListComponentProps,
+} from 'react-select';
+import { ThemeConfig } from '../styles';
+
+export type WindowedMenuListProps = {
+  selectProps: {
+    windowListRef?: RefObject<WindowedList>;
+    optionHeight?: number;
+  };
+};
+
+/**
+ * MenuListComponentProps should always have `children` elements, as guaranteed
+ * by https://github.com/JedWatson/react-select/blob/32ad5c040bdd96cd1ca71010c2558842d684629c/packages/react-select/src/Select.js#L1686-L1719
+ *
+ * `children` may also be `Component<NoticeProps<OptionType>>` if options are not
+ * provided (e.g., when async list is still loading, or no results), but that's
+ * not possible because this MenuList will only be rendered when
+ * optionsLength > windowThreshold.
+ *
+ * If may also be `Component<GroupProps<OptionType>>[]` but we are not supporting
+ * grouped options just yet.
+ */
+export type MenuListProps<
+  OptionType extends OptionTypeBase
+> = MenuListComponentProps<OptionType> & {
+  children: Component<OptionProps<OptionType>>[];
+  // theme is not present with built-in @types/react-select, but is actually
+  // available via CommonProps.
+  theme?: ThemeConfig;
+  className?: string;
+} & WindowedMenuListProps;
+
+/**
+ * Get the index of the last selected option.
+ */
+function getLastSelected(children: Component<any>[]) {
+  return Array.isArray(children)
+    ? Math.max(
+        children.findIndex(
+          ({ props: { isFocused = false } = {} }) => isFocused,
+        ),
+        0,
+      )
+    : -1;
+}
+
+/**
+ * Calculate probable option height as set in theme configs
+ */
+function detectHeight({ spacing: { baseUnit, lineHeight } }: ThemeConfig) {
+  return baseUnit * 4 + lineHeight;

Review comment:
       It's the size of top and bottom paddings combined. I don't think a constant helps much here. Will add comments to make it clear.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on issue #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f8adfc8fbfb7b97dd1205bfd2bb7c2582f76dfc4&el=desc) will **decrease** coverage by `0.20%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.54%   70.34%   -0.21%     
   ==========================================
     Files         574      182     -392     
     Lines       30133    17681   -12452     
     Branches     3066        0    -3066     
   ==========================================
   - Hits        21257    12437    -8820     
   + Misses       8765     5244    -3521     
   + Partials      111        0     -111     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.34% <ø> (-0.26%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.23%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.37% <0.00%> (-0.16%)` | :arrow_down: |
   | [superset-frontend/src/modules/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvdXRpbHMuanM=) | | |
   | ... and [377 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [f8adfc8...74a1180](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0 and enable sortable multi-select

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d167afb9499d7ce30c7ea763b19993af347dc23&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.72%   70.66%   -0.06%     
   ==========================================
     Files         584      182     -402     
     Lines       30382    17818   -12564     
     Branches     3112        0    -3112     
   ==========================================
   - Hits        21487    12591    -8896     
   + Misses       8781     5227    -3554     
   + Partials      114        0     -114     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.66% <ø> (-0.22%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: |
   | ... and [367 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [5d167af...a5606a0](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/34df11a61c79e8bbd1892825866714345f88748a&el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.89%   70.96%   +0.06%     
   ==========================================
     Files         585      184     -401     
     Lines       30427    17863   -12564     
     Branches     3152        0    -3152     
   ==========================================
   - Hits        21572    12676    -8896     
   + Misses       8744     5187    -3557     
   + Partials      111        0     -111     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.96% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `100.00% <ø> (ø)` | |
   | [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | `13.84% <ø> (ø)` | |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <ø> (-0.23%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.25% <0.00%> (-0.89%)` | :arrow_down: |
   | [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | | |
   | [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | | |
   | [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | | |
   | ... and [356 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [34df11a...a33b1ec](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13c5b133a9d054b07dff5bbcff987551e3c4c42e&el=desc) will **decrease** coverage by `6.92%`.
   > The diff coverage is `80.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   - Coverage   70.93%   64.01%   -6.93%     
   ==========================================
     Files         183      541     +358     
     Lines       17847    29247   +11400     
     Branches        0     2852    +2852     
   ==========================================
   + Hits        12660    18722    +6062     
   - Misses       5187    10332    +5145     
   - Partials        0      193     +193     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.22% <80.50%> (?)` | |
   | #python | `70.90% <ø> (-0.04%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `1.88% <ø> (ø)` | |
   | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `94.44% <ø> (ø)` | |
   | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `82.35% <ø> (ø)` | |
   | [...rset-frontend/src/components/OptionDescription.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT3B0aW9uRGVzY3JpcHRpb24uanN4) | `33.33% <ø> (ø)` | |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `48.03% <0.00%> (ø)` | |
   | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | |
   | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `5.47% <0.00%> (ø)` | |
   | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `71.42% <ø> (ø)` | |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <ø> (ø)` | |
   | [...components/AdhocFilterEditPopoverSqlTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU3FsVGFiQ29udGVudC5qc3g=) | `91.17% <ø> (ø)` | |
   | ... and [392 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [13c5b13...0b0a699](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r421891283



##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/histogram.js
##########
@@ -72,7 +72,6 @@ export default () =>
             comparator: 'boy',
             clause: 'WHERE',
             sqlExpression: null,
-            fromFormData: true,

Review comment:
       This was used to detect whether an adhoc metric/filter comes from stored metadata. It is used to automatically open the edit popover when adding a new metric/filter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9628: WIP: upgrade react-select from v1.3.0 to v3.1.0

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-618095127


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report
   > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f8adfc8fbfb7b97dd1205bfd2bb7c2582f76dfc4&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9628      +/-   ##
   ==========================================
   + Coverage   70.54%   70.59%   +0.05%     
   ==========================================
     Files         574      182     -392     
     Lines       30133    17681   -12452     
     Branches     3066        0    -3066     
   ==========================================
   - Hits        21257    12482    -8775     
   + Misses       8765     5199    -3566     
   + Partials      111        0     -111     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.59% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...nents/gridComponents/new/DraggableNewComponent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9EcmFnZ2FibGVOZXdDb21wb25lbnQuanN4) | | |
   | [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
   | [superset-frontend/src/components/Button.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uLmpzeA==) | | |
   | [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | | |
   | [...end/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS90cmFuc2Zvcm1Qcm9wcy5qcw==) | | |
   | [superset-frontend/src/components/FaveStar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIuanN4) | | |
   | [superset-frontend/src/CRUD/CollectionTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLmpzeA==) | | |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | | |
   | [superset-frontend/src/utils/reducerUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==) | | |
   | [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | | |
   | ... and [368 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [f8adfc8...74a1180](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org