You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/12/04 02:16:40 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request #13928: Separate cdc basic classes from scaling-core module and move to cdc-core module

sandynz opened a new pull request #13928:
URL: https://github.com/apache/shardingsphere/pull/13928


   Fixes #13875 part 4.
   
   Changes proposed in this pull request:
   - Refactor `ScalingConstant` into `CDCDataChangeType` and `MigrationConstant`. Separate SCALING_ROOT path of registry center (`/scaling`).
   - Remove scaling exception dependency of AbstractInventoryDumper. Separate from scaling.
   - Remove ScalingContext dependency of Channel impl. Separate from scaling.
   - Separate `TaskConfiguration` from `DataSourceManager`. Separate from scaling.
   - Move position, config, record, datasource, channel and dumper classes to `cdc-core` module
   - Move related unit test to `cdc-core` module
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu merged pull request #13928: Separate cdc basic classes from scaling-core module and move to cdc-core module

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #13928:
URL: https://github.com/apache/shardingsphere/pull/13928


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] codecov-commenter commented on pull request #13928: Separate cdc basic classes from scaling-core module and move to cdc-core module

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13928:
URL: https://github.com/apache/shardingsphere/pull/13928#issuecomment-985954157


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13928?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#13928](https://codecov.io/gh/apache/shardingsphere/pull/13928?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (393af20) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3b50c8b3862cadbf12c91545ce0b1b110dd43b7e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b50c8b) will **decrease** coverage by `0.22%`.
   > The diff coverage is `72.13%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/13928/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/13928?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #13928      +/-   ##
   ============================================
   - Coverage     63.94%   63.72%   -0.23%     
   - Complexity     1766     1768       +2     
   ============================================
     Files          2799     2799              
     Lines         41719    41722       +3     
     Branches       7133     7133              
   ============================================
   - Hits          26678    26588      -90     
   - Misses        13004    13101      +97     
   + Partials       2037     2033       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13928?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...re/channel/distribution/AbstractBitSetChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvY2hhbm5lbC9kaXN0cmlidXRpb24vQWJzdHJhY3RCaXRTZXRDaGFubmVsLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...e/channel/distribution/AutoAcknowledgeChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvY2hhbm5lbC9kaXN0cmlidXRpb24vQXV0b0Fja25vd2xlZGdlQ2hhbm5lbC5qYXZh) | `100.00% <ø> (ø)` | |
   | [...core/channel/distribution/DistributionChannel.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvY2hhbm5lbC9kaXN0cmlidXRpb24vRGlzdHJpYnV0aW9uQ2hhbm5lbC5qYXZh) | `87.32% <ø> (ø)` | |
   | [...re/cdc/core/channel/distribution/ManualBitSet.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvY2hhbm5lbC9kaXN0cmlidXRpb24vTWFudWFsQml0U2V0LmphdmE=) | `97.77% <ø> (ø)` | |
   | [...ingsphere/cdc/core/config/DumperConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvY29uZmlnL0R1bXBlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../cdc/core/config/InventoryDumperConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvY29uZmlnL0ludmVudG9yeUR1bXBlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...gsphere/cdc/core/datasource/DataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvZGF0YXNvdXJjZS9EYXRhU291cmNlRmFjdG9yeS5qYXZh) | `0.00% <ø> (ø)` | |
   | [...gsphere/cdc/core/datasource/DataSourceManager.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvZGF0YXNvdXJjZS9EYXRhU291cmNlTWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...gsphere/cdc/core/datasource/DataSourceWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvZGF0YXNvdXJjZS9EYXRhU291cmNlV3JhcHBlci5qYXZh) | `60.86% <ø> (ø)` | |
   | [...ingsphere/cdc/core/datasource/MetaDataManager.java](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNjaGVkdWxlL3NoYXJkaW5nc3BoZXJlLWNkYy9zaGFyZGluZ3NwaGVyZS1jZGMtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY2RjL2NvcmUvZGF0YXNvdXJjZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | ... and [77 more](https://codecov.io/gh/apache/shardingsphere/pull/13928/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13928?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13928?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3b50c8b...393af20](https://codecov.io/gh/apache/shardingsphere/pull/13928?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org