You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/11/09 16:10:27 UTC

[GitHub] [helix] helix-bot opened a new pull request, #2271: 2270/custom ca

helix-bot opened a new pull request, #2271:
URL: https://github.com/apache/helix/pull/2271

   ### Description
   
   <!-- Write a concise description: "what?, why?, how?" and then add some details about this PR, including screenshots of any UI changes -->
   
   <!-- This PR fixes this Helix issue & includes the Helix issue in the PR description. Link your issue number here: You can write `Fix #123`.  See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue -->
   
   This PR adds support for a configurable custom CA bundle to helix-front.
   
   Fix #2270
   
   ### Tests
   
   Tested locally.
   
   <details>
   
   ### Code Style
   
   <!-- Ensure the PR diff has been formatted using [Prettier](https://prettier.io) -->
   
   Formatted using [Prettier](https://prettier.io)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - [ ] My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: -->
   
   <!-- Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method or API behavior. -->
   
   ### Documentation (Optional)
   
   - [ ] In case of new functionality, my PR adds documentation in the following wiki page: -->
   
   <!-- Link the GitHub wiki you added -->
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] mgao0 commented on a diff in pull request #2271: 2270/custom ca

Posted by GitBox <gi...@apache.org>.
mgao0 commented on code in PR #2271:
URL: https://github.com/apache/helix/pull/2271#discussion_r1018484913


##########
helix-front/server/controllers/d.ts:
##########
@@ -1,6 +1,7 @@
 import { Request } from 'express';
+import request from 'request';
 
-export interface HelixUserRequest extends Request {
+export interface HelixRequest extends Request {

Review Comment:
   Is there a reason for changing interface name here? Could this change break backward compatibility?



##########
helix-front/angular.json:
##########
@@ -72,7 +72,8 @@
         "serve": {
           "builder": "@angular-devkit/build-angular:dev-server",
           "options": {
-            "proxyConfig": "./proxy.conf.json"
+            "proxyConfig": "./proxy.conf.json",
+            "disableHostCheck": true

Review Comment:
   Could you please explain this option? I don't have much context here. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] helix-bot commented on pull request #2271: 2270/custom ca

Posted by GitBox <gi...@apache.org>.
helix-bot commented on PR #2271:
URL: https://github.com/apache/helix/pull/2271#issuecomment-1310911046

   This PR is ready to be merged, approved by @mgao0  
   Final commit message:
   ## Configurable Custom CA Bundle for helix-front (#2271 )
    Add support for a configurable custom certificate authority bundle to helix-front.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] helix-bot commented on a diff in pull request #2271: 2270/custom ca

Posted by GitBox <gi...@apache.org>.
helix-bot commented on code in PR #2271:
URL: https://github.com/apache/helix/pull/2271#discussion_r1018582928


##########
helix-front/server/controllers/d.ts:
##########
@@ -1,6 +1,7 @@
 import { Request } from 'express';
+import request from 'request';
 
-export interface HelixUserRequest extends Request {
+export interface HelixRequest extends Request {

Review Comment:
   Thank you for the question @mgao0. The reasoning here is that since we use this interface in both the general-purpose `helix` controller and the `user` controller, that this interface should have a more general-purpose name like `HelixRequest`.  Does that make sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] mgao0 commented on a diff in pull request #2271: 2270/custom ca

Posted by GitBox <gi...@apache.org>.
mgao0 commented on code in PR #2271:
URL: https://github.com/apache/helix/pull/2271#discussion_r1019563607


##########
helix-front/server/controllers/d.ts:
##########
@@ -1,6 +1,7 @@
 import { Request } from 'express';
+import request from 'request';
 
-export interface HelixUserRequest extends Request {
+export interface HelixRequest extends Request {

Review Comment:
   This makes sense. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] mgao0 commented on a diff in pull request #2271: 2270/custom ca

Posted by GitBox <gi...@apache.org>.
mgao0 commented on code in PR #2271:
URL: https://github.com/apache/helix/pull/2271#discussion_r1019564517


##########
helix-front/angular.json:
##########
@@ -72,7 +72,8 @@
         "serve": {
           "builder": "@angular-devkit/build-angular:dev-server",
           "options": {
-            "proxyConfig": "./proxy.conf.json"
+            "proxyConfig": "./proxy.conf.json",
+            "disableHostCheck": true

Review Comment:
   Thanks for the explanation. Looks good



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] helix-bot commented on a diff in pull request #2271: 2270/custom ca

Posted by GitBox <gi...@apache.org>.
helix-bot commented on code in PR #2271:
URL: https://github.com/apache/helix/pull/2271#discussion_r1018585256


##########
helix-front/angular.json:
##########
@@ -72,7 +72,8 @@
         "serve": {
           "builder": "@angular-devkit/build-angular:dev-server",
           "options": {
-            "proxyConfig": "./proxy.conf.json"
+            "proxyConfig": "./proxy.conf.json",
+            "disableHostCheck": true

Review Comment:
   Yes, of course. Here is the context: 
   https://stackoverflow.com/questions/43677629/invalid-host-header-when-running-angular-cli-development-server-c9-io
   
   The summary is that during development, we may want to use a different host than `localhost`, like for example `app.localhost`, in order to test a feature like cookie handling that depends on the hostname having certain properties (like containing a period, for example).
   
   This `disableHostCheck` option tells the UI framework (Angular) local development server to disable the check that would otherwise cause an error when we use a custom hostname like `app.localhost`.
   
   For reference, here is the [docs page](https://angular.io/cli/serve) for Angular Serve that documents this configuration option. Does that help? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] NealSun96 merged pull request #2271: 2270/custom ca

Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2271:
URL: https://github.com/apache/helix/pull/2271


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org