You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by jo...@apache.org on 2016/09/07 21:03:25 UTC
spark git commit: [SPARK-17052][SQL] Remove Duplicate Test Cases
auto_join from HiveCompatibilitySuite.scala
Repository: spark
Updated Branches:
refs/heads/master 649fa4bf1 -> b230fb92a
[SPARK-17052][SQL] Remove Duplicate Test Cases auto_join from HiveCompatibilitySuite.scala
### What changes were proposed in this pull request?
The original [JIRA Hive-1642](https://issues.apache.org/jira/browse/HIVE-1642) delivered the test cases `auto_joinXYZ` for verifying the results when the joins are automatically converted to map-join. Basically, most of them are just copied from the corresponding `joinXYZ`.
After comparison between `auto_joinXYZ` and `joinXYZ`, below is a list of duplicate cases:
```
"auto_join0",
"auto_join1",
"auto_join10",
"auto_join11",
"auto_join12",
"auto_join13",
"auto_join14",
"auto_join14_hadoop20",
"auto_join15",
"auto_join17",
"auto_join18",
"auto_join2",
"auto_join20",
"auto_join21",
"auto_join23",
"auto_join24",
"auto_join3",
"auto_join4",
"auto_join5",
"auto_join6",
"auto_join7",
"auto_join8",
"auto_join9"
```
We can remove all of them without affecting the test coverage.
### How was this patch tested?
N/A
Author: gatorsmile <ga...@gmail.com>
Closes #14635 from gatorsmile/removeAuto.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/b230fb92
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/b230fb92
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/b230fb92
Branch: refs/heads/master
Commit: b230fb92a53375b648fa0f9e1d852270156d79e5
Parents: 649fa4b
Author: gatorsmile <ga...@gmail.com>
Authored: Wed Sep 7 14:03:14 2016 -0700
Committer: Josh Rosen <jo...@databricks.com>
Committed: Wed Sep 7 14:03:14 2016 -0700
----------------------------------------------------------------------
.../hive/execution/HiveCompatibilitySuite.scala | 50 ++++++++++----------
1 file changed, 26 insertions(+), 24 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/b230fb92/sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
----------------------------------------------------------------------
diff --git a/sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala b/sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
index a54d234..bebcb8f 100644
--- a/sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
+++ b/sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveCompatibilitySuite.scala
@@ -553,7 +553,32 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
"union31",
"union_date",
"varchar_2",
- "varchar_join1"
+ "varchar_join1",
+
+ // These tests are duplicates of joinXYZ
+ "auto_join0",
+ "auto_join1",
+ "auto_join10",
+ "auto_join11",
+ "auto_join12",
+ "auto_join13",
+ "auto_join14",
+ "auto_join14_hadoop20",
+ "auto_join15",
+ "auto_join17",
+ "auto_join18",
+ "auto_join2",
+ "auto_join20",
+ "auto_join21",
+ "auto_join23",
+ "auto_join24",
+ "auto_join3",
+ "auto_join4",
+ "auto_join5",
+ "auto_join6",
+ "auto_join7",
+ "auto_join8",
+ "auto_join9"
)
/**
@@ -573,37 +598,14 @@ class HiveCompatibilitySuite extends HiveQueryFileTest with BeforeAndAfter {
"annotate_stats_part",
"annotate_stats_table",
"annotate_stats_union",
- "auto_join0",
- "auto_join1",
- "auto_join10",
- "auto_join11",
- "auto_join12",
- "auto_join13",
- "auto_join14",
- "auto_join14_hadoop20",
- "auto_join15",
- "auto_join17",
- "auto_join18",
"auto_join19",
- "auto_join2",
- "auto_join20",
- "auto_join21",
"auto_join22",
- "auto_join23",
- "auto_join24",
"auto_join25",
"auto_join26",
"auto_join27",
"auto_join28",
- "auto_join3",
"auto_join30",
"auto_join31",
- "auto_join4",
- "auto_join5",
- "auto_join6",
- "auto_join7",
- "auto_join8",
- "auto_join9",
"auto_join_nulls",
"auto_join_reordering_values",
"binary_constant",
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org