You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Anders Morken (JIRA)" <de...@db.apache.org> on 2006/01/18 16:45:42 UTC

[jira] Created: (DERBY-823) Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays

Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays
---------------------------------------------------------------------------------------------

         Key: DERBY-823
         URL: http://issues.apache.org/jira/browse/DERBY-823
     Project: Derby
        Type: Sub-task
    Reporter: Anders Morken




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (DERBY-823) Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays

Posted by "David Van Couvering (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-823?page=all ]
     
David Van Couvering resolved DERBY-823:
---------------------------------------

    Fix Version: 10.2.0.0
     Resolution: Fixed

Committed revision 370240

> Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays
> ---------------------------------------------------------------------------------------------
>
>          Key: DERBY-823
>          URL: http://issues.apache.org/jira/browse/DERBY-823
>      Project: Derby
>         Type: Sub-task
>   Components: Newcomer
>     Reporter: Anders Morken
>     Assignee: Anders Morken
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: derbyclientnet.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Updated: (DERBY-823) Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays

Posted by "David W. Van Couvering" <Da...@Sun.COM>.
The patch looks good, I'm building and will run some basic sanity tests 
and will check it in.

David

Anders Morken (JIRA) wrote:
>      [ http://issues.apache.org/jira/browse/DERBY-823?page=all ]
> 
> Anders Morken updated DERBY-823:
> --------------------------------
> 
>     Attachment: derbyclientnet.patch
> 
> This minor patch changes a few for loops into equivalent uses of System.arraycopy() and java.util.Arrays.fill().
> 
> 
>>Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays
>>---------------------------------------------------------------------------------------------
>>
>>         Key: DERBY-823
>>         URL: http://issues.apache.org/jira/browse/DERBY-823
>>     Project: Derby
>>        Type: Sub-task
>>    Reporter: Anders Morken
>> Attachments: derbyclientnet.patch
>>
> 
> 
> 

[jira] Updated: (DERBY-823) Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays

Posted by "Anders Morken (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-823?page=all ]

Anders Morken updated DERBY-823:
--------------------------------

    Attachment: derbyclientnet.patch

This minor patch changes a few for loops into equivalent uses of System.arraycopy() and java.util.Arrays.fill().

> Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays
> ---------------------------------------------------------------------------------------------
>
>          Key: DERBY-823
>          URL: http://issues.apache.org/jira/browse/DERBY-823
>      Project: Derby
>         Type: Sub-task
>     Reporter: Anders Morken
>  Attachments: derbyclientnet.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DERBY-823) Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays

Posted by "Anders Morken (JIRA)" <de...@db.apache.org>.
    [ http://issues.apache.org/jira/browse/DERBY-823?page=comments#action_12363111 ] 

Anders Morken commented on DERBY-823:
-------------------------------------

Modified by the above patch:
M      java/client/org/apache/derby/client/net/Request.java
M      java/client/org/apache/derby/client/net/Reply.java

derbyall ran with a few failures that seemed to be related to locale handling:

********* Diff file derbyall/derbynetclientmats/DerbyNetClient/derbynetmats/derbynetmats/sysinfo.
diff
*** Start: sysinfo jdk1.4.2_09 DerbyNetClient derbynetmats:derbynetmats 2006-01-18 01:26:09 ***
17 del
< Current Locale :  [English/United States [en_US]]
17a17
> Current Locale :  [English/Norway [en_NO]]
44 del
< Current Locale :  [English/United States [en_US]]
44a44
> Current Locale :  [English/Norway [en_NO]]
72 del
< Current Locale :  [English/United States [en_US]]
72a72
> Current Locale :  [English/Norway [en_NO]]
Test Failed.
*** End:   sysinfo jdk1.4.2_09 DerbyNetClient derbynetmats:derbynetmats 2006-01-18 01:26:13 ***


> Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays
> ---------------------------------------------------------------------------------------------
>
>          Key: DERBY-823
>          URL: http://issues.apache.org/jira/browse/DERBY-823
>      Project: Derby
>         Type: Sub-task
>     Reporter: Anders Morken
>  Attachments: derbyclientnet.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (DERBY-823) Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays

Posted by "Anders Morken (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-823?page=all ]
     
Anders Morken closed DERBY-823:
-------------------------------


Thank you, guys, for finding me a nice newcomer task and accepting the patch. =)

> Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays
> ---------------------------------------------------------------------------------------------
>
>          Key: DERBY-823
>          URL: http://issues.apache.org/jira/browse/DERBY-823
>      Project: Derby
>         Type: Sub-task
>   Components: Newcomer
>     Reporter: Anders Morken
>     Assignee: Anders Morken
>     Priority: Trivial
>      Fix For: 10.2.0.0
>  Attachments: derbyclientnet.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DERBY-823) Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays

Posted by "Anders Morken (JIRA)" <de...@db.apache.org>.
     [ http://issues.apache.org/jira/browse/DERBY-823?page=all ]

Anders Morken updated DERBY-823:
--------------------------------

      Component: Newcomer
    Description: 
    Environment: 
      Assign To: Anders Morken
       Priority: Trivial  (was: Major)

> Minor patches to client/net/(Reply|Request).java to use System.arrayCopy and java.util.Arrays
> ---------------------------------------------------------------------------------------------
>
>          Key: DERBY-823
>          URL: http://issues.apache.org/jira/browse/DERBY-823
>      Project: Derby
>         Type: Sub-task
>   Components: Newcomer
>     Reporter: Anders Morken
>     Assignee: Anders Morken
>     Priority: Trivial
>  Attachments: derbyclientnet.patch
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira