You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org> on 2018/04/24 21:36:33 UTC
[Impala-ASF-CR] IMPALA-6902: Tighten udf test to look for crashes
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10180
Change subject: IMPALA-6902: Tighten udf test to look for crashes
......................................................................
IMPALA-6902: Tighten udf test to look for crashes
test_native_functions_race assumes that any exception
is grounds for failing the test. However, the flake described
in IMPALA-6902 shows an example of an exception that causes
a false negative (it should be ignored). This change tightens
the test to fail when an impalad crashes, which was the original
intent of the test.
Tests:
- re-ran test_udfs.py
Change-Id: I7780ff328fde5cf462cf718a1467b8a032d2c17b
---
M tests/query_test/test_udfs.py
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/10180/1
--
To view, visit http://gerrit.cloudera.org:8080/10180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7780ff328fde5cf462cf718a1467b8a032d2c17b
Gerrit-Change-Number: 10180
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6902: Tighten udf test to look for crashes
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10180 )
Change subject: IMPALA-6902: Tighten udf test to look for crashes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7780ff328fde5cf462cf718a1467b8a032d2c17b
Gerrit-Change-Number: 10180
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Apr 2018 21:50:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6902: Tighten udf test to look for crashes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10180 )
Change subject: IMPALA-6902: Tighten udf test to look for crashes
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7780ff328fde5cf462cf718a1467b8a032d2c17b
Gerrit-Change-Number: 10180
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Apr 2018 07:28:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6902: Tighten udf test to look for crashes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10180 )
Change subject: IMPALA-6902: Tighten udf test to look for crashes
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2358/
--
To view, visit http://gerrit.cloudera.org:8080/10180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7780ff328fde5cf462cf718a1467b8a032d2c17b
Gerrit-Change-Number: 10180
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Apr 2018 03:42:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6902: Tighten udf test to look for crashes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10180 )
Change subject: IMPALA-6902: Tighten udf test to look for crashes
......................................................................
IMPALA-6902: Tighten udf test to look for crashes
test_native_functions_race assumes that any exception
is grounds for failing the test. However, the flake described
in IMPALA-6902 shows an example of an exception that causes
a false negative (it should be ignored). This change tightens
the test to fail when an impalad crashes, which was the original
intent of the test.
Tests:
- re-ran test_udfs.py
Change-Id: I7780ff328fde5cf462cf718a1467b8a032d2c17b
Reviewed-on: http://gerrit.cloudera.org:8080/10180
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_udfs.py
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Thomas Tauber-Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10180
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7780ff328fde5cf462cf718a1467b8a032d2c17b
Gerrit-Change-Number: 10180
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>