You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/04/27 18:39:59 UTC
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/
-----------------------------------------------------------
(Updated April 27, 2018, 11:39 a.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and Vinod Kone.
Repository: mesos
Description
-------
Added FrameworkMetrics struct in framework struct.
Diffs (updated)
-----
src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828
src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2
Diff: https://reviews.apache.org/r/66819/diff/3/
Changes: https://reviews.apache.org/r/66819/diff/2-3/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/#review202662
-----------------------------------------------------------
src/master/metrics.hpp
Lines 219-221 (patched)
<https://reviews.apache.org/r/66819/#comment284601>
This constructor should be implemented in this patch.
The implementation is introduced in https://reviews.apache.org/r/66820/ with extra parameters.
- Gaston Kleiman
On April 27, 2018, 11:39 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66819/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 11:39 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkMetrics struct in framework struct.
>
>
> Diffs
> -----
>
> src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828
> src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2
>
>
> Diff: https://reviews.apache.org/r/66819/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/
-----------------------------------------------------------
(Updated July 10, 2018, 3:40 p.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Bugs: MESOS-8919
https://issues.apache.org/jira/browse/MESOS-8919
Repository: mesos
Description
-------
Added FrameworkMetrics struct in framework struct.
Diffs (updated)
-----
src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66819/diff/7/
Changes: https://reviews.apache.org/r/66819/diff/6-7/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/#review205817
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.hpp
Lines 2974 (patched)
<https://reviews.apache.org/r/66819/#comment288722>
s/framwork/framework/
- Gastón Kleiman
On June 27, 2018, 12:34 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66819/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 12:34 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8919
> https://issues.apache.org/jira/browse/MESOS-8919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkMetrics struct in framework struct.
>
>
> Diffs
> -----
>
> src/master/master.hpp 4180341e2c7b16503a4376c501f611bb78ba901c
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66819/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/#review205813
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On June 27, 2018, 7:34 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66819/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 7:34 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8919
> https://issues.apache.org/jira/browse/MESOS-8919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkMetrics struct in framework struct.
>
>
> Diffs
> -----
>
> src/master/master.hpp 4180341e2c7b16503a4376c501f611bb78ba901c
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66819/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/
-----------------------------------------------------------
(Updated June 27, 2018, 12:34 a.m.)
Review request for mesos, Benjamin Mahler, Gastón Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Bugs: MESOS-8919
https://issues.apache.org/jira/browse/MESOS-8919
Repository: mesos
Description
-------
Added FrameworkMetrics struct in framework struct.
Diffs (updated)
-----
src/master/master.hpp 4180341e2c7b16503a4376c501f611bb78ba901c
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66819/diff/6/
Changes: https://reviews.apache.org/r/66819/diff/5-6/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/#review203264
-----------------------------------------------------------
src/master/master.hpp
Lines 2993 (patched)
<https://reviews.apache.org/r/66819/#comment285367>
I think this CHECK will fail when a scheduler subscribes for the first time? Check out this callsite: https://github.com/apache/mesos/blob/eb9ab8089ae9bcb5779454fb2a6ce18b51a9a0cb/src/master/master.cpp#L2688
- Greg Mann
On May 16, 2018, 12:33 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66819/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 12:33 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-8919
> https://issues.apache.org/jira/browse/MESOS-8919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkMetrics struct in framework struct.
>
>
> Diffs
> -----
>
> src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66819/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/
-----------------------------------------------------------
(Updated May 15, 2018, 5:33 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Bugs: MESOS-8919
https://issues.apache.org/jira/browse/MESOS-8919
Repository: mesos
Description
-------
Added FrameworkMetrics struct in framework struct.
Diffs
-----
src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66819/diff/5/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/
-----------------------------------------------------------
(Updated May 15, 2018, 5:31 p.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
Added FrameworkMetrics struct in framework struct.
Diffs (updated)
-----
src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66819/diff/5/
Changes: https://reviews.apache.org/r/66819/diff/4-5/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/#review203073
-----------------------------------------------------------
src/master/metrics.hpp
Lines 221 (patched)
<https://reviews.apache.org/r/66819/#comment285148>
Is this parameter used?
- Greg Mann
On May 11, 2018, 7:20 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66819/
> -----------------------------------------------------------
>
> (Updated May 11, 2018, 7:20 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkMetrics struct in framework struct.
>
>
> Diffs
> -----
>
> src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718
> src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
> src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
>
>
> Diff: https://reviews.apache.org/r/66819/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/
-----------------------------------------------------------
(Updated May 11, 2018, 12:20 a.m.)
Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, and Vinod Kone.
Changes
-------
rebased.
Repository: mesos
Description
-------
Added FrameworkMetrics struct in framework struct.
Diffs (updated)
-----
src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718
src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b
src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66819/diff/4/
Changes: https://reviews.apache.org/r/66819/diff/3-4/
Testing
-------
Thanks,
Gilbert Song