You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/03/26 18:37:34 UTC
[kudu-CR](branch-1.7.x) [rpc-test] macOS-specific fix for TestRpcSidecarLimits
Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9801
to review the following change.
Change subject: [rpc-test] macOS-specific fix for TestRpcSidecarLimits
......................................................................
[rpc-test] macOS-specific fix for TestRpcSidecarLimits
As Will noticed, after TestRpcSidecarLimits was updated with 2b0c1c0,
on macOS the following new error surfaced while running the test
(which is completely legit in accordance with 'man sendmsg'):
Network error: sendmsg error: Invalid argument (error 22)
This patch updates the pattern of the expected error message for the
case if sendmsg() returns EINVAL when the sum of the iov_len values
overflows an ssize_t.
This is a follow-up for 2b0c1c019921e485f06c4be280fedba3d5279672.
Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
Reviewed-on: http://gerrit.cloudera.org:8080/9719
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Will Berkeley <wd...@gmail.com>
(cherry picked from commit bc8a5029675e30962ec5126afe3cf12f3143d4d3)
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/9801/1
--
To view, visit http://gerrit.cloudera.org:8080/9801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
Gerrit-Change-Number: 9801
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.7.x) [rpc-test] macOS-specific fix for TestRpcSidecarLimits
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9801 )
Change subject: [rpc-test] macOS-specific fix for TestRpcSidecarLimits
......................................................................
[rpc-test] macOS-specific fix for TestRpcSidecarLimits
As Will noticed, after TestRpcSidecarLimits was updated with 2b0c1c0,
on macOS the following new error surfaced while running the test
(which is completely legit in accordance with 'man sendmsg'):
Network error: sendmsg error: Invalid argument (error 22)
This patch updates the pattern of the expected error message for the
case if sendmsg() returns EINVAL when the sum of the iov_len values
overflows an ssize_t.
This is a follow-up for 2b0c1c019921e485f06c4be280fedba3d5279672.
Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
Reviewed-on: http://gerrit.cloudera.org:8080/9719
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Will Berkeley <wd...@gmail.com>
(cherry picked from commit bc8a5029675e30962ec5126afe3cf12f3143d4d3)
Reviewed-on: http://gerrit.cloudera.org:8080/9801
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
Gerrit-Change-Number: 9801
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.7.x) [rpc-test] macOS-specific fix for TestRpcSidecarLimits
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9801 )
Change subject: [rpc-test] macOS-specific fix for TestRpcSidecarLimits
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
Gerrit-Change-Number: 9801
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.7.x) [rpc-test] macOS-specific fix for TestRpcSidecarLimits
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9801 )
Change subject: [rpc-test] macOS-specific fix for TestRpcSidecarLimits
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
Gerrit-Change-Number: 9801
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:54:11 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) [rpc-test] macOS-specific fix for TestRpcSidecarLimits
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9801 )
Change subject: [rpc-test] macOS-specific fix for TestRpcSidecarLimits
......................................................................
Patch Set 1: Verified+1
Build failure due to the following error:
libtool: Version mismatch error. This is libtool 2.4.2 Debian-2.4.2-1.7ubuntu1, but the definition of this LT_INIT comes from libtool 2.4.6.
Seems like some workspace issues? Anyway, I think it's safe to ignore this because it's unrelated to the change.
--
To view, visit http://gerrit.cloudera.org:8080/9801
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I17681546fd942724025dfde81eaa412ee7e0acbf
Gerrit-Change-Number: 9801
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 19:53:11 +0000
Gerrit-HasComments: No