You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/31 05:44:17 UTC
[GitHub] [flink] JingGe opened a new pull request, #19848: [hotfix][doc] fix typo and enlarge image
JingGe opened a new pull request, #19848:
URL: https://github.com/apache/flink/pull/19848
## What is the purpose of the change
the deployment modes image is too small to read the text.
## Brief change log
- enlarge the image
- fix typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingGe commented on a diff in pull request #19848: [hotfix][doc] fix typo and enlarge image
Posted by GitBox <gi...@apache.org>.
JingGe commented on code in PR #19848:
URL: https://github.com/apache/flink/pull/19848#discussion_r885794542
##########
docs/content/docs/deployment/overview.md:
##########
@@ -183,7 +183,7 @@ Flink can execute applications in one of three ways:
<!-- Image source: https://docs.google.com/drawings/d/1EfloufuOp1A7YDwZmBEsHKRLIrrbtRkoWRPcfZI5RYQ/edit?usp=sharing -->
-{{< img class="img-fluid" width="80%" style="margin: 15px" src="/fig/deployment_modes.svg" alt="Figure for Deployment Modes" >}}
+{{< img class="img-fluid" width="100%" style="margin: 15px" src="/fig/deployment_modes.svg" alt="Figure for Deployment Modes" >}}
Review Comment:
Because this picture contains smaller text that is really hard to read. https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/overview/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19848: [hotfix][doc] fix typo and enlarge image
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19848:
URL: https://github.com/apache/flink/pull/19848#issuecomment-1141691968
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7c256ccd02c8fe6f2c1f4023276cdd184dbd6053",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7c256ccd02c8fe6f2c1f4023276cdd184dbd6053",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c256ccd02c8fe6f2c1f4023276cdd184dbd6053 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 merged pull request #19848: [hotfix][doc] fix typo and enlarge image
Posted by GitBox <gi...@apache.org>.
wangyang0918 merged PR #19848:
URL: https://github.com/apache/flink/pull/19848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a diff in pull request #19848: [hotfix][doc] fix typo and enlarge image
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #19848:
URL: https://github.com/apache/flink/pull/19848#discussion_r885621851
##########
docs/content/docs/deployment/overview.md:
##########
@@ -183,7 +183,7 @@ Flink can execute applications in one of three ways:
<!-- Image source: https://docs.google.com/drawings/d/1EfloufuOp1A7YDwZmBEsHKRLIrrbtRkoWRPcfZI5RYQ/edit?usp=sharing -->
-{{< img class="img-fluid" width="80%" style="margin: 15px" src="/fig/deployment_modes.svg" alt="Figure for Deployment Modes" >}}
+{{< img class="img-fluid" width="100%" style="margin: 15px" src="/fig/deployment_modes.svg" alt="Figure for Deployment Modes" >}}
Review Comment:
Why do we need to change the width? It seems that other pictures are also configured `80%` width.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on a diff in pull request #19848: [hotfix][doc] fix typo and enlarge image
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #19848:
URL: https://github.com/apache/flink/pull/19848#discussion_r886252080
##########
docs/content/docs/deployment/overview.md:
##########
@@ -183,7 +183,7 @@ Flink can execute applications in one of three ways:
<!-- Image source: https://docs.google.com/drawings/d/1EfloufuOp1A7YDwZmBEsHKRLIrrbtRkoWRPcfZI5RYQ/edit?usp=sharing -->
-{{< img class="img-fluid" width="80%" style="margin: 15px" src="/fig/deployment_modes.svg" alt="Figure for Deployment Modes" >}}
+{{< img class="img-fluid" width="100%" style="margin: 15px" src="/fig/deployment_modes.svg" alt="Figure for Deployment Modes" >}}
Review Comment:
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org