You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by as...@apache.org on 2026/09/01 15:20:15 UTC
(maka) branch ci/4480-classify-planner-fallback-paths updated (ca93ed3e6d -> f447318e6b)
This is an automated email from the ASF dual-hosted git repository.
Astro-Han pushed a change to branch ci/4480-classify-planner-fallback-paths
in repository https://gitbox.apache.org/repos/asf/maka.git
omit ca93ed3e6d ci: stop selecting the helper admission lane on an unrelated manifest
new f447318e6b ci: stop selecting the helper admission lane on an unrelated manifest
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (ca93ed3e6d)
\
N -- N -- N refs/heads/ci/4480-classify-planner-fallback-paths (f447318e6b)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
scripts/ci-workflow-policy.test.mjs | 42 +++++++++++++++++--------------------
1 file changed, 19 insertions(+), 23 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
(maka) 01/01: ci: stop selecting the helper admission lane on an unrelated manifest
Posted by as...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
Astro-Han pushed a commit to branch ci/4480-classify-planner-fallback-paths
in repository https://gitbox.apache.org/repos/asf/maka.git
commit f447318e6bfd69ddd960197d2531c002511ce01b
Author: AstroHan <le...@outlook.com>
AuthorDate: Tue Sep 1 23:09:38 2026 +0800
ci: stop selecting the helper admission lane on an unrelated manifest
`packages/runtime/package.json` has been in this lane's path filter since
#3561, where it stood for a source-import dependency. That dependency is not
there any more — `packages/runtime` contains no Gitoxide reference of any kind,
and every source this lane reads is already named directly: the crate, the
three `runtime-host` server modules, and their suites.
It was the lane's dominant trigger regardless: 12 of 16 selections across the
last 300 first-parent commits. Workspace manifest diffs are dominated by
`"version"` and npm script edits, so each of those spent three runners —
`ubuntu-latest`, `macos-latest`, `windows-latest` — building and testing a Rust
crate whose inputs had not moved. Replayed after the change the lane selects
4 of 300 instead of 16.
What is given up is the indirect case where `packages/runtime`'s build script
changes what `npm --workspace @maka/runtime run build` produces here. That was
never covered consistently — this job builds four workspaces and only one of
their manifests was listed — and `npm run build` under the `code` surface,
which selects on 94.7% of commits, reaches all four before this lane would.
The new assertion is about the failure mode rather than about this one entry:
every path in the filter has to name Gitoxide or be a file that mentions it.
Nothing was checking that, which is why an entry could go stale in place and
keep allocating runners for years. Restating the current list instead would
have locked in a past judgement and blocked the legitimate case where this
manifest earns its way back.
Refs #4480
---
.github/workflows/gitoxide-helper-admission.yml | 2 --
scripts/ci-workflow-policy.test.mjs | 22 ++++++++++++++++++++++
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/gitoxide-helper-admission.yml b/.github/workflows/gitoxide-helper-admission.yml
index 5d16b4dab1..0a0463ea40 100644
--- a/.github/workflows/gitoxide-helper-admission.yml
+++ b/.github/workflows/gitoxide-helper-admission.yml
@@ -26,7 +26,6 @@ on:
- 'packages/runtime-host/src/__tests__/gitoxide-helper-*.test.ts'
- 'packages/runtime-host/src/server/gitoxide-repository-admission-authority-internal.ts'
- 'packages/runtime-host/src/__tests__/gitoxide-repository-admission-authority-internal.test.ts'
- - 'packages/runtime/package.json'
- 'docs/architecture/gitoxide-*.md'
push:
branches:
@@ -38,7 +37,6 @@ on:
- 'packages/runtime-host/src/__tests__/gitoxide-helper-*.test.ts'
- 'packages/runtime-host/src/server/gitoxide-repository-admission-authority-internal.ts'
- 'packages/runtime-host/src/__tests__/gitoxide-repository-admission-authority-internal.test.ts'
- - 'packages/runtime/package.json'
- 'docs/architecture/gitoxide-*.md'
permissions:
diff --git a/scripts/ci-workflow-policy.test.mjs b/scripts/ci-workflow-policy.test.mjs
index ffa9f0169a..02b2df2972 100644
--- a/scripts/ci-workflow-policy.test.mjs
+++ b/scripts/ci-workflow-policy.test.mjs
@@ -375,6 +375,28 @@ test('the recovery lane pairs its path filter with a nightly run and a main push
assert.match(readWorkflow('windows-recovery.yml'), /\n {4}name: windows_recovery/u);
});
+test('every path the helper admission lane filters on can reach Gitoxide', () => {
+ // Three runners build four workspaces and run three suites here, so an entry
+ // that cannot change a Gitoxide outcome spends three runners proving nothing.
+ // A stale entry is the failure mode this catches: `packages/runtime`'s
+ // manifest sat in this list from #3561 for a source-import dependency that
+ // has since gone, and nothing noticed, because nothing was checking that a
+ // filter entry still reaches the subject.
+ for (const path of pullRequestPathFilter('gitoxide-helper-admission.yml')) {
+ // Naming the subject is enough on its own, and every entry does that today.
+ if (/gitoxide/iu.test(path)) continue;
+
+ // Otherwise the file it names has to mention it. A wildcard that does not
+ // name the subject is rejected rather than expanded: it would let one
+ // matching file admit every sibling that does not.
+ assert.doesNotMatch(path, /[*?]/u, `${path}: wildcard that never names Gitoxide`);
+
+ const source = new URL(`../${path}`, import.meta.url);
+ assert.ok(existsSync(source), `${path}: filtered but absent`);
+ assert.match(readFileSync(source, 'utf8'), /gitoxide/iu, `${path}: no Gitoxide reference`);
+ }
+});
+
test('installed-package validation discards superseded pull request runs', () => {
const workflow = readWorkflow('cli-package-validation.yml');
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org