You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:40:11 UTC

[GitHub] [flink] zhijiangW opened a new pull request #13012: [FLINK-18595][network] Fix the deadlock of concurrently recycling buffer and releasing input channel

zhijiangW opened a new pull request #13012:
URL: https://github.com/apache/flink/pull/13012


   ## What is the purpose of the change
   
   Assuming two remote channels with buffer managers as listeners in LocalBufferPool, the deadlock happens as follows:
   
   While the Canceler thread calling ch1#releaseAllResources, it will occupy the bufferQueue lock of bm1 and try to call bm2#notifyBufferAvailable.
   
   While the task thread recycling exclusive buffer for ch2, then it will occupy the bufferQueue lock of bm2 and try to call bm1#notifyBufferAvailable.
   
   These two threads will both occupy the respective bm's bufferQueue lock and wait for other side's bufferQueue lock to cause deadlock.
   
   Regarding the solution, we can check the released state outside of bufferQueue lock in BufferManager#notifyBufferAvailable to return immediately.
   
   ## Brief change log
   
   check the released state outside of bufferQueue lock in BufferManager#notifyBufferAvailable to return immediately.
   
   ## Verifying this change
   
   Verified by existing ITCase StreamFaultToleranceTestBase
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhijiangW closed pull request #13012: [FLINK-18595][network] Fix the deadlock of concurrently recycling buffer and releasing input channel

Posted by GitBox <gi...@apache.org>.

zhijiangW closed pull request #13012:
URL: https://github.com/apache/flink/pull/13012


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13012: [FLINK-18595][network] Fix the deadlock of concurrently recycling buffer and releasing input channel

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13012:
URL: https://github.com/apache/flink/pull/13012#issuecomment-665443259

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 244a29783a58a8127a36a1add64d591cc077c76d (Wed Jul 29 05:39:29 UTC 2020)

**Warnings:**
* **29 pom.xml files were touched**: Check for build and licensing issues.

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhijiangW commented on pull request #13012: [FLINK-18595][network] Fix the deadlock of concurrently recycling buffer and releasing input channel

Posted by GitBox <gi...@apache.org>.

zhijiangW commented on pull request #13012:
URL: https://github.com/apache/flink/pull/13012#issuecomment-665442591


   Invalid one, closed. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org