[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #12765: [FIX][DOC-12764]fix sql-hive and hive-cli doc

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #12765:
URL: https://github.com/apache/dolphinscheduler/pull/12765#discussion_r1015084455


##########
docs/docs/en/guide/task/sql.md:
##########
@@ -38,6 +38,7 @@ Refer to [datasource-setting](../howto/datasource-setting.md) `DataSource Center
 #### Create a Temporary Table in Hive and Write Data
 
 This example creates a temporary table `tmp_hello_world` in Hive and writes a row of data. Before creating a temporary table, we need to ensure that the table does not exist. So we use custom parameters to obtain the time of the day as the suffix of the table name every time we run, this task can run every different day. The format of the created table name is: `tmp_hello_world_{yyyyMMdd}`.
+**Note**：the hive datasource in the SQL task based on JDBC to execute SQLs, SQL statement does not support multi-statements, please avoid using ';' at the end of the statement. To process multi-statements please use Hive-Cli task.

Review Comment:
   And BTW, can we use hyperlink here? 
   
   ```
   To process multi-statements please use [Hive-Cli](./hive-cli.md) task.
   ```



##########
docs/docs/en/guide/task/sql.md:
##########
@@ -38,6 +38,7 @@ Refer to [datasource-setting](../howto/datasource-setting.md) `DataSource Center
 #### Create a Temporary Table in Hive and Write Data
 
 This example creates a temporary table `tmp_hello_world` in Hive and writes a row of data. Before creating a temporary table, we need to ensure that the table does not exist. So we use custom parameters to obtain the time of the day as the suffix of the table name every time we run, this task can run every different day. The format of the created table name is: `tmp_hello_world_{yyyyMMdd}`.
+**Note**：the hive datasource in the SQL task based on JDBC to execute SQLs, SQL statement does not support multi-statements, please avoid using ';' at the end of the statement. To process multi-statements please use Hive-Cli task.

Review Comment:
   should we also remove this statement?
   <img width="1416" alt="image" src="https://user-images.githubusercontent.com/15820530/200251958-b753908d-abb3-4f94-ae00-dd19b19b25fb.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org