You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/03/28 17:29:51 UTC
[GitHub] [incubator-hudi] ovj commented on a change in pull request #616:
Fixes HUDI-38: Reduce memory overhead of WriteStatus
ovj commented on a change in pull request #616: Fixes HUDI-38: Reduce memory overhead of WriteStatus
URL: https://github.com/apache/incubator-hudi/pull/616#discussion_r270116594
##########
File path: hoodie-client/src/main/java/com/uber/hoodie/WriteStatus.java
##########
@@ -48,6 +51,16 @@
private long totalRecords = 0;
private long totalErrorRecords = 0;
+ private final double failureFraction;
+ private final boolean trackSuccessRecords;
+ private final transient Random random;
+
+ public WriteStatus(Boolean trackSuccessRecords, Double failureFraction) {
Review comment:
any reason to user "Boolean" / "Double" over "boolean" / "double"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services