[GitHub] [spark] bersprockets commented on a diff in pull request #40717: [MINOR][SQL][TESTS] Tests in `SubquerySuite` should not drop view created in `beforeAll`

["bersprockets (via GitHub)" <gi...@apache.org>]

bersprockets commented on code in PR #40717:
URL: https://github.com/apache/spark/pull/40717#discussion_r1161333229


##########
sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala:
##########
@@ -2699,22 +2699,17 @@ class SubquerySuite extends QueryTest
   test("SPARK-42937: Outer join with subquery in condition") {
     withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "false",
       SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "false") {
-      withTempView("t2") {
-        // this is the same as the view t created in beforeAll, but that gets dropped by
-        // one of the tests above
-        r.filter($"c".isNotNull && $"d".isNotNull).createOrReplaceTempView("t2")

Review Comment:
   This test no longer needs to re-create `t` (here named `t2`), because `t` is now available for this test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org