You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/04 08:08:04 UTC

[GitHub] [flink] twalthr commented on a diff in pull request #20119: [FLINK-28322][table-api] DataStreamScan(Sink)Provider's new method is not compatible

twalthr commented on code in PR #20119:
URL: https://github.com/apache/flink/pull/20119#discussion_r912736423


##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/connector/source/DataStreamScanProvider.java:
##########
@@ -48,8 +48,10 @@ public interface DataStreamScanProvider extends ScanTableSource.ScanRuntimeProvi
      *
      * @see SingleOutputStreamOperator#uid(String)
      */
-    DataStream<RowData> produceDataStream(
-            ProviderContext providerContext, StreamExecutionEnvironment execEnv);
+    default DataStream<RowData> produceDataStream(

Review Comment:
   Just out of curiosity: Will this prevent errors in downstream systems? Previously implemented lambas will still fail, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org