[aries-journaled-events] branch master updated: Remove TopicPosition as we do not support partitions

[cs...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cschneider pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/aries-journaled-events.git


The following commit(s) were added to refs/heads/master by this push:
     new 050cdc9  Remove TopicPosition as we do not support partitions
050cdc9 is described below

commit 050cdc9da6e777099ccbcaa86a301a85e5eecd82
Author: Christian Schneider <cs...@adobe.com>
AuthorDate: Mon Dec 31 09:45:15 2018 +0100

    Remove TopicPosition as we do not support partitions
---
 .../src/main/java/org/apache/aries/events/api/Messaging.java        | 2 +-
 .../src/main/java/org/apache/aries/events/api/Position.java         | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Messaging.java b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Messaging.java
index 7432799..e2f9308 100644
--- a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Messaging.java
+++ b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Messaging.java
@@ -22,7 +22,7 @@ public interface Messaging {
      * @param callback will be called for each message received
      * @return Returned subscription must be closed by the caller to unsubscribe
      */
-    Subscription subscribe(String topic, TopicPosition position, Seek seek, Consumer<Message> callback);
+    Subscription subscribe(String topic, Position position, Seek seek, Consumer<Message> callback);
 
     /**
      * Create a message with payload and metadata
diff --git a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Position.java b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Position.java
index 4e1c8ee..7a85039 100644
--- a/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Position.java
+++ b/org.apache.aries.events.api/src/main/java/org/apache/aries/events/api/Position.java
@@ -1,8 +1,10 @@
 package org.apache.aries.events.api;
 
 /**
- * Implementation dependent position in a the topic.
- * E.g. For a kafka implementation this would be a list of (partition, offset)
+ * Position in a the topic.
+ * E.g. For a kafka implementation this would be a list of (partition, offset) as we do not support partitions 
+ * this could simply be like an offset.
+ * TODO How do we provide ordering without being too specific?
  */
 public interface Position {