You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2025/04/25 13:09:34 UTC
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22817
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
IMPALA-13993: waitForHmsEvent should check table events under missing dbs
When a db is missing in the catalog cache, waitForHmsEvent request
currently just check if there are pending database events on it,
assuming processing the CREATE_DATABASE event will add the db with
the table list. However, that's wrong since processing CREATE_DATABASE
event just adds the db with an empty table list. We should still wait
for pending events on underlying tables.
Tests:
- Added e2e test which consistenly fails when running concurrently with
other tests in TestEventSyncWaiting without the fix.
Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M tests/metadata/test_event_processing.py
2 files changed, 16 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/22817/1
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 3: Verified+1
> Patch Set 3: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11792/
The failure is unrelated to this patch:
https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/5242/testReport/junit/org.apache.impala.customcluster/JwtHttpTest/testJwtAuthWithUntrustedJwksHttpsUrl/
Track it in IMPALA-11945. Merging this.
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 28 Apr 2025 01:06:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11792/
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Apr 2025 14:37:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22817
to look at the new patch set (#2).
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
IMPALA-13993: waitForHmsEvent should check table events under missing dbs
When a db is missing in the catalog cache, waitForHmsEvent request
currently just check if there are pending database events on it,
assuming processing the CREATE_DATABASE event will add the db with
the table list. However, that's wrong since processing CREATE_DATABASE
event just adds the db with an empty table list. We should still wait
for pending events on underlying tables.
Tests:
- Added e2e test which consistenly fails when running concurrently with
other tests in TestEventSyncWaiting without the fix.
Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M tests/metadata/test_event_processing.py
2 files changed, 16 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/22817/2
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Apr 2025 14:49:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11792/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Apr 2025 08:28:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19012/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Apr 2025 13:36:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 2:
rebased onto master
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Apr 2025 08:27:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 1: Code-Review+1
Thanks for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Apr 2025 14:21:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Apr 2025 08:28:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
IMPALA-13993: waitForHmsEvent should check table events under missing dbs
When a db is missing in the catalog cache, waitForHmsEvent request
currently just check if there are pending database events on it,
assuming processing the CREATE_DATABASE event will add the db with
the table list. However, that's wrong since processing CREATE_DATABASE
event just adds the db with an empty table list. We should still wait
for pending events on underlying tables.
Tests:
- Added e2e test which consistenly fails when running concurrently with
other tests in TestEventSyncWaiting without the fix.
Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Reviewed-on: http://gerrit.cloudera.org:8080/22817
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M tests/metadata/test_event_processing.py
2 files changed, 16 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19030/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Apr 2025 08:53:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13993: waitForHmsEvent should check table events under missing dbs
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22817 )
Change subject: IMPALA-13993: waitForHmsEvent should check table events under missing dbs
......................................................................
Patch Set 2: Code-Review+2
Carry +2 from Riza and Daniel.
--
To view, visit http://gerrit.cloudera.org:8080/22817
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3fe74fcf0bf4dbac4a3584f6603279c0a2730b0c
Gerrit-Change-Number: 22817
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 27 Apr 2025 08:28:17 +0000
Gerrit-HasComments: No