You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2015/04/23 18:54:00 UTC
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/5666
[SPARK-5553][SQL] Replace Array[Byte] with Java NIO ByteBuffer as binary type representation
JIRA: https://issues.apache.org/jira/browse/SPARK-5553
This pr attempts to replace Array[Byte] with Java NIO ByteBuffer as SQL binary type representation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 bytebuffer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5666.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5666
----
commit d77990f0b1d51114e32956d8ce08adfa1f6eff30
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2015-04-23T16:47:43Z
Replace Array[Byte] with Java NIO ByteBuffer as binary type representation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95653046
[Test build #30852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30852/consoleFull) for PR 5666 at commit [`d77990f`](https://github.com/apache/spark/commit/d77990f0b1d51114e32956d8ce08adfa1f6eff30).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95668372
[Test build #30858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30858/consoleFull) for PR 5666 at commit [`68c9b00`](https://github.com/apache/spark/commit/68c9b006606e12d0b7e5a27e74e4469581ca45b8).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95658408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30852/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95673533
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30858/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95743535
ok. I'm closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95658377
[Test build #30852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30852/consoleFull) for PR 5666 at commit [`d77990f`](https://github.com/apache/spark/commit/d77990f0b1d51114e32956d8ce08adfa1f6eff30).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95673520
[Test build #30858 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30858/consoleFull) for PR 5666 at commit [`68c9b00`](https://github.com/apache/spark/commit/68c9b006606e12d0b7e5a27e74e4469581ca45b8).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95674982
Thanks for submitting this. It's our fault to have that JIRA ticket there and suggest nio.ByteBuffer.
ByteBuffer is not the right abstraction for this. It's API is pretty clunky (flip, etc), and cannot be serialized. We will do something as part of https://issues.apache.org/jira/browse/SPARK-7075
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5666#issuecomment-95673967
Hey, we probably do want to do this at some point, but I'm not sure the answer is ByteBuffer. Big changes like this should be proposed in JIRA and discussed before coding begins. Since we are close to the merge deadline for Spark 1.4 it is unlikely this patch will be merged anytime soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5553][SQL] Replace Array[Byte] with Jav...
Posted by viirya <gi...@git.apache.org>.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/5666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org