You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "fullmooooon (via GitHub)" <gi...@apache.org> on 2023/02/23 03:23:19 UTC

[GitHub] [echarts] fullmooooon opened a new pull request, #18301: Delete \asset\contributing-inspect.png

fullmooooon opened a new pull request, #18301:
URL: https://github.com/apache/echarts/pull/18301

   
   ![image](https://user-images.githubusercontent.com/43309591/220813193-a8041876-231a-4d46-9aaa-297e9dc6efe1.png)
   
   
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   
   I found this PNG in my "node_modules\echarts" folder. I checked it in the repository. This PNG is not associated with any files in the current code base. Although this 235 KB image only accounts for 0.5% of the entire folder, it is unreasonable to add extra useless files on thousands of front-end developers' computers
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] fullmooooon commented on a diff in pull request #18301: Ignore file '\asset\contributing-inspect.png' when publish to npm

Posted by "fullmooooon (via GitHub)" <gi...@apache.org>.
fullmooooon commented on code in PR #18301:
URL: https://github.com/apache/echarts/pull/18301#discussion_r1115531411


##########
.npmignore:
##########
@@ -10,5 +10,6 @@
 .DS_Store
 Thumbs.db
 Desktop.ini
+/asset/contributing-inspect.png

Review Comment:
   edited again



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] fullmooooon commented on pull request #18301: Ignore file '\asset\contributing-inspect.png' when publish to npm

Posted by "fullmooooon (via GitHub)" <gi...@apache.org>.
fullmooooon commented on PR #18301:
URL: https://github.com/apache/echarts/pull/18301#issuecomment-1441500554

   @plainheart Thank you for your suggestion. It has been revised.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] plainheart merged pull request #18301: Ignore files about 'contributing' when publish to npm

Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart merged PR #18301:
URL: https://github.com/apache/echarts/pull/18301


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] plainheart commented on a diff in pull request #18301: Ignore file '\asset\contributing-inspect.png' when publish to npm

Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on code in PR #18301:
URL: https://github.com/apache/echarts/pull/18301#discussion_r1115506865


##########
.npmignore:
##########
@@ -10,5 +10,6 @@
 .DS_Store
 Thumbs.db
 Desktop.ini
+/asset/contributing-inspect.png

Review Comment:
   <del>We can ignore the whole `asset` folder </del> and the `CONTRIBUTING.md` seems also unnecessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #18301: Delete \asset\contributing-inspect.png

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18301:
URL: https://github.com/apache/echarts/pull/18301#issuecomment-1441169516

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] plainheart commented on a diff in pull request #18301: Ignore file '\asset\contributing-inspect.png' when publish to npm

Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on code in PR #18301:
URL: https://github.com/apache/echarts/pull/18301#discussion_r1115506865


##########
.npmignore:
##########
@@ -10,5 +10,6 @@
 .DS_Store
 Thumbs.db
 Desktop.ini
+/asset/contributing-inspect.png

Review Comment:
   We can ignore the whole `asset` folder and the `CONTRIBUTING.md` seems also unnecessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #18301: Ignore files about 'contributing' when publish to npm

Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18301:
URL: https://github.com/apache/echarts/pull/18301#issuecomment-1441587034

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org