[jira] [Work logged] (IO-661) FileUtils throws inconsistent exceptions

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IO-661?focusedWorklogId=420171&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420171 ]

ASF GitHub Bot logged work on IO-661:
-------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Apr/20 11:27
            Start Date: 10/Apr/20 11:27
    Worklog Time Spent: 10m 
      Work Description: ferenc-csaky commented on pull request #111: [IO-661] FileUtils throws inconsistent exceptions
URL: https://github.com/apache/commons-io/pull/111
 
 
   Changed `IllegalArgumentException` to `IOException` in is thrown, but in `copyDirectoryToDirectory(...)` and `copeFileToDirectory(...)` functions. As the Jira mentions, the move equivalent throws `IOException` already. Furthermore, every other intermittent method which is called also throws `IOException` for the same, so I think this is the good choice here.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 420171)
    Remaining Estimate: 0h
            Time Spent: 10m

> FileUtils throws inconsistent exceptions
> ----------------------------------------
>
>                 Key: IO-661
>                 URL: https://issues.apache.org/jira/browse/IO-661
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.6
>            Reporter: Hao Zhong
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The FileUtils throws inconsistent exceptions, when an input is not a directory. 
> The copyFileToDirectory throws IllegalArgumentException:
>  
> {code:java}
>   public static void copyFileToDirectory(final File srcFile, final File destDir, final boolean preserveFileDate)
>             throws IOException {
>         if (destDir == null) {
>             throw new NullPointerException("Destination must not be null");
>         }
>         if (destDir.exists() && destDir.isDirectory() == false) {
>             throw new IllegalArgumentException("Destination '" + destDir + "' is not a directory");
>         }
>         final File destFile = new File(destDir, srcFile.getName());
>         copyFile(srcFile, destFile, preserveFileDate);
>     }
> {code}
> The other methods throw IOException:
>  
>  
> {code:java}
>  public static void moveFileToDirectory(final File srcFile, final File destDir, final boolean createDestDir)
>             throws IOException {
>         validateMoveParameters(srcFile, destDir);
>         if (!destDir.exists() && createDestDir) {
>             destDir.mkdirs();
>         }
>         if (!destDir.exists()) {
>             throw new FileNotFoundException("Destination directory '" + destDir +
>                     "' does not exist [createDestDir=" + createDestDir + "]");
>         }
>         if (!destDir.isDirectory()) {
>             throw new IOException("Destination '" + destDir + "' is not a directory");
>         }
>         moveFile(srcFile, new File(destDir, srcFile.getName()));
>     }
> {code}
> I feel that IOException is more reasonable. Although the messages are the same, the different exception can cause problems when programmers catch the thrown exceptions. 
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)