You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/01/21 15:40:05 UTC
[GitHub] [pinot] walterddr commented on a change in pull request #8055: Support BOOLEAN type in recommender engine
walterddr commented on a change in pull request #8055:
URL: https://github.com/apache/pinot/pull/8055#discussion_r789758920
##########
File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java
##########
@@ -157,15 +168,13 @@ void testQueryInvertedSortedIndexRecommender()
add("[[PredicateParseResult{dims{[3]}, AND, BITMAP, nESI=1.645, selected=0.034, nESIWithIdx=0.695}, "
+ "PredicateParseResult{dims{[2]},"
+ " AND, BITMAP, nESI=1.645, selected=0.034, nESIWithIdx=0.835}, PredicateParseResult{dims{[]}, AND, "
- + "NESTED, nESI=1.645, "
- + "selected=0.034, nESIWithIdx=1.645}]]");
+ + "NESTED, nESI=1.645, " + "selected=0.034, nESIWithIdx=1.645}]]");
Review comment:
nit: could you get rid of the unnecessary `" + "` here and below?
##########
File path: pinot-controller/src/test/java/org/apache/pinot/controller/recommender/TestConfigEngine.java
##########
@@ -89,6 +89,17 @@ void testInputManager()
assertTrue(_input.getTimeColumns().contains("t"));
}
+ @Test
+ void testSupportsBooleanDataType()
+ throws InvalidInputException, IOException {
+ loadInput("recommenderInput/BooleanInput.json");
+ assertEquals(_input.getFieldType("a"), DataType.BOOLEAN);
Review comment:
nit: FieldSpc.DataType.BOOLEAN. to avoid additional import
##########
File path: pinot-controller/src/test/resources/recommenderInput/BooleanInput.json
##########
@@ -0,0 +1,34 @@
+{
Review comment:
i dont think we need a dedicated input json for boolean. would you be able to add a field and on additional query in SortedInvertedIndexInput.json?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org