You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "albilu (via GitHub)" <gi...@apache.org> on 2023/05/20 09:00:47 UTC

[GitHub] [netbeans] albilu opened a new pull request, #5971: Adding org.eclipse.lsp4j.debug and org.eclipse.lsp4j.jsonrpc.debug dependencies

albilu opened a new pull request, #5971:
URL: https://github.com/apache/netbeans/pull/5971

   Fix for #5950
   Allowing LSP Client to use not only the LSP Client but also the DAP Client


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] albilu commented on pull request #5971: Adding org.eclipse.lsp4j.debug and org.eclipse.lsp4j.jsonrpc.debug dependencies to LSP Client

Posted by "albilu (via GitHub)" <gi...@apache.org>.
albilu commented on PR #5971:
URL: https://github.com/apache/netbeans/pull/5971#issuecomment-1595849658

   Updated lsp4j-0.13.0-license.txt and ignored-overlaps files as 1 check (Check Paperwork on Linux/JDK 11) previously failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #5971: Adding org.eclipse.lsp4j.debug and org.eclipse.lsp4j.jsonrpc.debug dependencies to LSP Client

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5971:
URL: https://github.com/apache/netbeans/pull/5971#issuecomment-1567426528

   In general this change makes sense to me, though there might be alternatives. I assume, that you get two different gson versions in your classpath and that is what blows.
   
   For the change:
   - please increment the second component of the spec version (can be updated in place)
   - please update the commit with your real name and valid e-mail address (currently your nickname and the github noreply address is listed)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #5971: Adding org.eclipse.lsp4j.debug and org.eclipse.lsp4j.jsonrpc.debug dependencies to LSP Client

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5971:
URL: https://github.com/apache/netbeans/pull/5971#issuecomment-1599363181

   If noone objects, I'll merge next weekend. Thank you for the work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] albilu commented on pull request #5971: Adding org.eclipse.lsp4j.debug and org.eclipse.lsp4j.jsonrpc.debug dependencies to LSP Client

Posted by "albilu (via GitHub)" <gi...@apache.org>.
albilu commented on PR #5971:
URL: https://github.com/apache/netbeans/pull/5971#issuecomment-1586087117

   
   
   
   > In general this change makes sense to me, though there might be alternatives. I assume, that you get two different gson versions in your classpath and that is what blows.
   
   Yes right. But seems more complicated as the packages in LSP client are not public so i tried to exclude the gson from LSP client and many different solution but didn't work.
   
   Spec Version updated!
   Commit Amended with valid user name/email.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing merged pull request #5971: Adding org.eclipse.lsp4j.debug and org.eclipse.lsp4j.jsonrpc.debug dependencies to LSP Client

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #5971:
URL: https://github.com/apache/netbeans/pull/5971


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists