[jira] [Comment Edited] (MJAVADOC-570) --add-modules expects comma-separated arguments

["Gili (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAVADOC-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753161#comment-16753161 ] 

Gili edited comment on MJAVADOC-570 at 1/26/19 7:49 PM:
--------------------------------------------------------

Taking a look at the code, this seems to affect everything.

Every single place we are invoking {{addArgIfNotEmpty}} it is converting legitimate separators into newlines. Maybe I should just change the default "splitValue" from "true" to "false"?


was (Author: cowwoc):
This a look at the code, this seems to affect everything.

Every single place we are invoking {{addArgIfNotEmpty}} it is converting legitimate separators into newlines. Maybe I should just change the default "splitValue" from "true" to "false"?

> --add-modules expects comma-separated arguments
> -----------------------------------------------
>
>                 Key: MJAVADOC-570
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-570
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>          Components: javadoc
>    Affects Versions: 3.1.0
>            Reporter: Gili
>            Priority: Major
>
> It's quicker for me to explain this problem that produce a minimal testcase for it. In AbstractJavadocMojo line 5079 we invoke:
> {code:java}
> addArgIfNotEmpty( arguments, "--add-modules", JavadocUtil.quotedPathArgument(addModulesLine ) );{code}
> This gets converted to {{addArgIfNotEmpty()}} with {{splitValue=true}} which means that comma-separated values get converted to newline-separated values. 
> {{--add-modules}} does not like this and does not consume the subsequent arguments (they probably get treated as source files instead).
> We should be invoking {{addArgIfNotEmpty()}} with {{splitValue=false}} instead.
> If I provide a PR for this, do you still need a testcase?
> On a side-note, it would really help if they documented the expected behavior. I only ran across this by chance due to this bug report on OpenJDK: https://bugs.openjdk.java.net/browse/JDK-8165634



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)