You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/06/14 22:39:12 UTC

[GitHub] [maven-resolver] elharo commented on a change in pull request #53: [MRESOLVER-115] make checksum algorithms configurable

elharo commented on a change in pull request #53:
URL: https://github.com/apache/maven-resolver/pull/53#discussion_r439874544



##########
File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/Maven2RepositoryLayoutFactory.java
##########
@@ -155,10 +168,12 @@ public URI getLocation( Metadata metadata, boolean upload )
 
         private List<Checksum> getChecksums( URI location )
         {
-            return Arrays.asList( Checksum.forLocation( location, "SHA-512" ),
-                                  Checksum.forLocation( location, "SHA-256" ),
-                                  Checksum.forLocation( location, "SHA-1" ),
-                                  Checksum.forLocation( location, "MD5" ) );
+            List<Checksum> checksums = new LinkedList<>( );

Review comment:
       nit: arraylist is almost always better, data structures textbooks to the contrary. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org