[GitHub] [parquet-mr] shangxinli commented on a change in pull request #869: PARQUET-1979: bloom_filter_offset is filled if there are no bloom filters

[GitBox <gi...@apache.org>]

shangxinli commented on a change in pull request #869:
URL: https://github.com/apache/parquet-mr/pull/869#discussion_r576383236



##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ColumnChunkMetaData.java
##########
@@ -157,14 +157,14 @@ public static ColumnChunkMetaData get(
           totalUncompressedSize);
     }
   }
-  
+
   // In sensitive columns, the ColumnMetaData structure is encrypted (with column-specific keys), making the fields like Statistics invisible.
   // Decryption is not performed pro-actively, due to performance and authorization reasons.
   // This method creates an a shell ColumnChunkMetaData object that keeps the encrypted metadata and the decryption tools.
   // These tools will activated later - when/if the column is projected.
-  public static ColumnChunkMetaData getWithEncryptedMetadata(ParquetMetadataConverter parquetMetadataConverter, ColumnPath path, 
+  public static ColumnChunkMetaData getWithEncryptedMetadata(ParquetMetadataConverter parquetMetadataConverter, ColumnPath path,

Review comment:
       Is this intentionally changed? I see multiple places have changed like this.  These kinds of changes could cause other pending PRs conflict. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org