You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by ma...@apache.org on 2010/02/06 02:15:41 UTC
svn commit: r907153 - in /hadoop/avro/trunk: CHANGES.txt lang/c/Makefile.am
lang/c/examples/Makefile.am lang/c/examples/quickstop.c
lang/c/src/Makefile.am lang/c/src/schema.h lang/c/tests/Makefile.am
Author: massie
Date: Sat Feb 6 01:15:40 2010
New Revision: 907153
URL: http://svn.apache.org/viewvc?rev=907153&view=rev
Log:
AVRO-400. Adding warning for unused parameters (contributed by Eli Collins)
Modified:
hadoop/avro/trunk/CHANGES.txt
hadoop/avro/trunk/lang/c/Makefile.am
hadoop/avro/trunk/lang/c/examples/Makefile.am
hadoop/avro/trunk/lang/c/examples/quickstop.c
hadoop/avro/trunk/lang/c/src/Makefile.am
hadoop/avro/trunk/lang/c/src/schema.h
hadoop/avro/trunk/lang/c/tests/Makefile.am
Modified: hadoop/avro/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/avro/trunk/CHANGES.txt?rev=907153&r1=907152&r2=907153&view=diff
==============================================================================
--- hadoop/avro/trunk/CHANGES.txt (original)
+++ hadoop/avro/trunk/CHANGES.txt Sat Feb 6 01:15:40 2010
@@ -311,6 +311,8 @@
AVRO-403. Add file object container support to C implementation (massie)
+ AVRO-400. Adding warning for unused parameters (Eli Collins via massie)
+
OPTIMIZATIONS
AVRO-172. More efficient schema processing (massie)
Modified: hadoop/avro/trunk/lang/c/Makefile.am
URL: http://svn.apache.org/viewvc/hadoop/avro/trunk/lang/c/Makefile.am?rev=907153&r1=907152&r2=907153&view=diff
==============================================================================
--- hadoop/avro/trunk/lang/c/Makefile.am (original)
+++ hadoop/avro/trunk/lang/c/Makefile.am Sat Feb 6 01:15:40 2010
@@ -8,7 +8,7 @@
cscope:
cd $(top_srcdir) ; \
- find src tests examples -iname '*.[chsSly]' > cscope.files ; \
+ find src tests examples jansson -iname '*.[chsSly]' > cscope.files ; \
cscope -kqb
pretty:
Modified: hadoop/avro/trunk/lang/c/examples/Makefile.am
URL: http://svn.apache.org/viewvc/hadoop/avro/trunk/lang/c/examples/Makefile.am?rev=907153&r1=907152&r2=907153&view=diff
==============================================================================
--- hadoop/avro/trunk/lang/c/examples/Makefile.am (original)
+++ hadoop/avro/trunk/lang/c/examples/Makefile.am Sat Feb 6 01:15:40 2010
@@ -1,6 +1,6 @@
# -pedantic
AM_CPPFLAGS=-I$(top_srcdir)/src
-AM_CFLAGS=-Wall
+AM_CFLAGS=-Wall -Wextra -Wunused-parameter
ACLOCAL_AMFLAGS=-I m4
check_PROGRAMS=quickstop
Modified: hadoop/avro/trunk/lang/c/examples/quickstop.c
URL: http://svn.apache.org/viewvc/hadoop/avro/trunk/lang/c/examples/quickstop.c?rev=907153&r1=907152&r2=907153&view=diff
==============================================================================
--- hadoop/avro/trunk/lang/c/examples/quickstop.c (original)
+++ hadoop/avro/trunk/lang/c/examples/quickstop.c Sat Feb 6 01:15:40 2010
@@ -114,7 +114,7 @@
}
if (avro_record_get(person, "Age", &age_datum) == 0) {
avro_int32_get(age_datum, &i32);
- fprintf(stdout, "%ld", i32);
+ fprintf(stdout, "%d", i32);
}
fprintf(stdout, "\n");
Modified: hadoop/avro/trunk/lang/c/src/Makefile.am
URL: http://svn.apache.org/viewvc/hadoop/avro/trunk/lang/c/src/Makefile.am?rev=907153&r1=907152&r2=907153&view=diff
==============================================================================
--- hadoop/avro/trunk/lang/c/src/Makefile.am (original)
+++ hadoop/avro/trunk/lang/c/src/Makefile.am Sat Feb 6 01:15:40 2010
@@ -1,6 +1,6 @@
# -pedantic
AM_CPPFLAGS=-I$(top_srcdir)/jansson/src
-AM_CFLAGS=-Wall
+AM_CFLAGS=-Wall -Wextra -Wunused-parameter
ACLOCAL_AMFLAGS=-I m4
include_HEADERS = avro.h
Modified: hadoop/avro/trunk/lang/c/src/schema.h
URL: http://svn.apache.org/viewvc/hadoop/avro/trunk/lang/c/src/schema.h?rev=907153&r1=907152&r2=907153&view=diff
==============================================================================
--- hadoop/avro/trunk/lang/c/src/schema.h (original)
+++ hadoop/avro/trunk/lang/c/src/schema.h Sat Feb 6 01:15:40 2010
@@ -61,7 +61,7 @@
struct avro_fixed_schema_t {
struct avro_obj_t obj;
const char *name;
- size_t size;
+ int64_t size;
};
struct avro_link_schema_t {
Modified: hadoop/avro/trunk/lang/c/tests/Makefile.am
URL: http://svn.apache.org/viewvc/hadoop/avro/trunk/lang/c/tests/Makefile.am?rev=907153&r1=907152&r2=907153&view=diff
==============================================================================
--- hadoop/avro/trunk/lang/c/tests/Makefile.am (original)
+++ hadoop/avro/trunk/lang/c/tests/Makefile.am Sat Feb 6 01:15:40 2010
@@ -1,6 +1,6 @@
# -pedantic
AM_CPPFLAGS=-I$(top_srcdir)/src
-AM_CFLAGS=-Wall
+AM_CFLAGS=-Wall -Wextra -Wunused-parameter
ACLOCAL_AMFLAGS=-I m4
EXTRA_DIST=schema_tests test_valgrind