You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2023/05/22 12:18:27 UTC
[GitHub] [ignite-3] tkalkirill opened a new pull request, #2096: IGNITE-19472 Make fsync flag configurable in RAFT
tkalkirill opened a new pull request, #2096:
URL: https://github.com/apache/ignite-3/pull/2096
https://issues.apache.org/jira/browse/IGNITE-19472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #2096: IGNITE-19472 Make fsync flag configurable in RAFT
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2096:
URL: https://github.com/apache/ignite-3/pull/2096#discussion_r1201593002
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -149,6 +149,8 @@ public Loza(
public void start() {
opts.setRpcInstallSnapshotTimeout(raftConfiguration.rpcInstallSnapshotTimeout().value());
+ opts.getRaftOptions().setSync(raftConfiguration.fsync().value());
Review Comment:
Should we first take `RaftView` and then use it to obtain the 2 settings (to make sure that we always get a consistent snapshot of the configuration)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2096: IGNITE-19472 Make fsync flag configurable in RAFT
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #2096:
URL: https://github.com/apache/ignite-3/pull/2096#discussion_r1201602756
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -149,6 +149,8 @@ public Loza(
public void start() {
opts.setRpcInstallSnapshotTimeout(raftConfiguration.rpcInstallSnapshotTimeout().value());
+ opts.getRaftOptions().setSync(raftConfiguration.fsync().value());
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill merged pull request #2096: IGNITE-19472 Make fsync flag configurable in RAFT
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #2096:
URL: https://github.com/apache/ignite-3/pull/2096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org