You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/12/19 03:02:07 UTC
Review Request 64699: Added a test to ensure quota headroom is
maintained.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64699/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-8339
https://issues.apache.org/jira/browse/MESOS-8339
Repository: mesos
Description
-------
This test verifies that quota headroom is correctly
maintained when some roles have more reservations than
their quota. We need to ensure that one role's excessive
reservaiton is not counted towards another role's quota
headroom.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 4127d0591e4abffa74720fecccb1999c1a808534
Diff: https://reviews.apache.org/r/64699/diff/1/
Testing
-------
make check.
Thanks,
Meng Zhu
Re: Review Request 64699: Added a test to ensure quota headroom is
maintained.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64699/#review194126
-----------------------------------------------------------
Ship it!
Very nice!
src/tests/hierarchical_allocator_tests.cpp
Lines 1763 (patched)
<https://reviews.apache.org/r/64699/#comment272858>
WhenReservationsExceedQuota
src/tests/hierarchical_allocator_tests.cpp
Lines 1805 (patched)
<https://reviews.apache.org/r/64699/#comment272859>
are no
- Benjamin Mahler
On Dec. 19, 2017, 3:02 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64699/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 3:02 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8339
> https://issues.apache.org/jira/browse/MESOS-8339
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that quota headroom is correctly
> maintained when some roles have more reservations than
> their quota. We need to ensure that one role's excessive
> reservaiton is not counted towards another role's quota
> headroom.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 4127d0591e4abffa74720fecccb1999c1a808534
>
>
> Diff: https://reviews.apache.org/r/64699/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64699: Added a test to ensure quota headroom is
maintained.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64699/#review194123
-----------------------------------------------------------
PASS: Mesos patch 64699 was successfully built and tested.
Reviews applied: `['64698', '64699']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64699
- Mesos Reviewbot Windows
On Dec. 19, 2017, 3:02 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64699/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 3:02 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-8339
> https://issues.apache.org/jira/browse/MESOS-8339
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that quota headroom is correctly
> maintained when some roles have more reservations than
> their quota. We need to ensure that one role's excessive
> reservaiton is not counted towards another role's quota
> headroom.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 4127d0591e4abffa74720fecccb1999c1a808534
>
>
> Diff: https://reviews.apache.org/r/64699/diff/1/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Meng Zhu
>
>