You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2008/10/21 06:40:44 UTC
[jira] Created: (ZOOKEEPER-200) the magic number for snapshot and
log must be different (currently same)
the magic number for snapshot and log must be different (currently same)
------------------------------------------------------------------------
Key: ZOOKEEPER-200
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
Project: Zookeeper
Issue Type: Bug
Components: server
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.0.0
the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-200) the magic number for snapshot and
log must be different (currently same)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641778#action_12641778 ]
Hudson commented on ZOOKEEPER-200:
----------------------------------
Integrated in ZooKeeper-trunk #121 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/121/])
. the magic number for snapshot and log must be different
> the magic number for snapshot and log must be different (currently same)
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-200
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-200.patch, ZOOKEEPER-200.patch
>
>
> the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-200) the magic number for snapshot and
log must be different (currently same)
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-200:
------------------------------------
Hadoop Flags: [Incompatible change, Reviewed]
+1 Good catch Pat. The fact that you didn't have to change any code that reads the logs and snapshots indicates that we are not checking the magic numbers, which is another bug :) Please commit.
> the magic number for snapshot and log must be different (currently same)
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-200
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-200.patch
>
>
> the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-200) the magic number for snapshot and
log must be different (currently same)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-200:
-----------------------------------
Status: Patch Available (was: In Progress)
> the magic number for snapshot and log must be different (currently same)
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-200
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-200.patch
>
>
> the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-200) the magic number for snapshot and
log must be different (currently same)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-200:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed] (was: [Reviewed, Incompatible change])
Status: Resolved (was: Patch Available)
Committed revision 706686.
> the magic number for snapshot and log must be different (currently same)
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-200
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-200.patch, ZOOKEEPER-200.patch
>
>
> the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (ZOOKEEPER-200) the magic number for snapshot
and log must be different (currently same)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on ZOOKEEPER-200 started by Patrick Hunt.
> the magic number for snapshot and log must be different (currently same)
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-200
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-200.patch
>
>
> the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-200) the magic number for snapshot and
log must be different (currently same)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-200:
-----------------------------------
Attachment: ZOOKEEPER-200.patch
Updated to fix merge conflict with latest svn.
> the magic number for snapshot and log must be different (currently same)
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-200
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-200.patch, ZOOKEEPER-200.patch
>
>
> the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-200) the magic number for snapshot and
log must be different (currently same)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-200:
-----------------------------------
Attachment: ZOOKEEPER-200.patch
changed snap magic to ZKSN and transaction log magic to ZKLG
> the magic number for snapshot and log must be different (currently same)
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-200
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-200.patch
>
>
> the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-200) the magic number for snapshot and
log must be different (currently same)
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641442#action_12641442 ]
Patrick Hunt commented on ZOOKEEPER-200:
----------------------------------------
ya, I created that last night - see ZOOKEEPER-201
> the magic number for snapshot and log must be different (currently same)
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-200
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-200
> Project: Zookeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-200.patch
>
>
> the magic number for the snapshot and transaction logs are currently the same - they should be different. Also the magic numbers should also be more indicative of the type of file (currently "AK47" for both, not very useful in determining type of file)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.