You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tdas <gi...@git.apache.org> on 2014/04/25 03:08:50 UTC
[GitHub] spark pull request: [SPARK-1510] Spark Streaming metrics source fo...
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/545
[SPARK-1510] Spark Streaming metrics source for metrics system
This pulls in changes made by @jerryshao in https://github.com/apache/spark/pull/424 and merges with the master.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tdas/spark streaming-metrics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #545
----
commit 976116bf151160a31ab8f26317170b46b046a7b0
Author: jerryshao <sa...@intel.com>
Date: 2014-04-16T07:22:25Z
Add StreamSource in StreamingContext for better monitoring through metrics system
commit 21939f53d9438ed458847bb5223329c005826d57
Author: jerryshao <sa...@intel.com>
Date: 2014-04-17T00:57:22Z
Style changes according to style check error
commit fb3b0a5881323caf151721f85f351c36b53ec6b8
Author: jerryshao <sa...@intel.com>
Date: 2014-04-24T08:21:40Z
Modify according master update
commit 034b44335b949d5e2e23bd853ce240e023a68f3b
Author: Tathagata Das <ta...@gmail.com>
Date: 2014-04-25T01:05:17Z
Merge remote-tracking branch 'apache-github/master' into streaming-metrics
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1510] Spark Streaming metrics source fo...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/545#issuecomment-41359040
Thanks TD, I will check the new additions in StreamingListener to see if we can add some new metrics for Spark Streaming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1510] Spark Streaming metrics source fo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/545#issuecomment-41352173
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1510] Spark Streaming metrics source fo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/545#issuecomment-41352177
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14467/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1510] Spark Streaming metrics source fo...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/545#issuecomment-41352461
I have merged this! Thanks @jerryshao
BTW, note that there are new additions to the StreamingListener interface that allows you to get the receiver state (running or not, where it is running, etc.). You may want to add those to the metrics source as well. This is merged, so you can create a new PR if you want.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1510] Spark Streaming metrics source fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/545
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1510] Spark Streaming metrics source fo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/545#issuecomment-41350506
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-1510] Spark Streaming metrics source fo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/545#issuecomment-41350511
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---