You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2013/07/08 11:45:48 UTC

[jira] [Commented] (HAMA-775) Disable compression option in hama-default.xml

    [ https://issues.apache.org/jira/browse/HAMA-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701898#comment-13701898 ] 

Edward J. Yoon commented on HAMA-775:
-------------------------------------

I've committed directly. 

{code}
### Eclipse Workspace Patch 1.0
#P hama-trunk
Index: core/src/main/java/org/apache/hama/bsp/message/HadoopMessageManagerImpl.java
===================================================================
--- core/src/main/java/org/apache/hama/bsp/message/HadoopMessageManagerImpl.java	(revision 1500626)
+++ core/src/main/java/org/apache/hama/bsp/message/HadoopMessageManagerImpl.java	(working copy)
@@ -104,6 +104,7 @@
       if (compressor != null
           && (bundle.getApproximateSize() > conf.getLong(
               "hama.messenger.compression.threshold", 1048576))) {
+        
         BSPCompressedBundle compMsgBundle = compressor.compressBundle(bundle);
         bspPeerConnection.put(compMsgBundle);
         peer.incrementCounter(BSPPeerImpl.PeerCounter.COMPRESSED_MESSAGES, 1L);
Index: conf/hama-default.xml
===================================================================
--- conf/hama-default.xml	(revision 1500626)
+++ conf/hama-default.xml	(working copy)
@@ -218,14 +218,15 @@
     <value>org.apache.hama.bsp.message.HadoopMessageManagerImpl</value>
   </property>
 
+  <!-- The message compression is not recommended for a large production environment -->
   <property>
     <name>hama.messenger.compression.class</name>
-    <value>org.apache.hama.bsp.message.compress.SnappyCompressor</value>
-    <description>The message compression algorithm to choose.</description>
+    <value></value>
+    <description>The message compression algorithm to choose. Default is null.</description>
   </property>
   <property>
     <name>hama.messenger.compression.threshold</name>
-    <value>1048576</value>
+    <value></value>
     <description>The Compressor threshold sets the level at which compression begins.</description>
   </property>
   
{code}
                
> Disable compression option in hama-default.xml
> ----------------------------------------------
>
>                 Key: HAMA-775
>                 URL: https://issues.apache.org/jira/browse/HAMA-775
>             Project: Hama
>          Issue Type: Improvement
>    Affects Versions: 0.6.2
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>            Priority: Trivial
>             Fix For: 0.6.3
>
>
> According to my experiences, real-time compression is not recommended.
> Let's remove from the default configuration. and consider again after Spilling Queue is done.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira