You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2014/06/02 19:44:02 UTC
[jira] [Commented] (HBASE-10336) Remove deprecated usage of Hadoop
HttpServer in InfoServer
[ https://issues.apache.org/jira/browse/HBASE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015628#comment-14015628 ]
stack commented on HBASE-10336:
-------------------------------
Looking at raw patch because rb not working for me:
Why a new 'conf' package?
conf/ServerConfigurationKeys.java
Are the keys used by master and regionserver? You don't want to put them in the Server interface or in HConstants? Or in the InfoServer or in 'http' package since the constants seem to pertain there?
I asked some questions on rb like how much of this is copy and paste from hadoop..... and do we have to pull it all in? E.g. HtmlQuoting.
I think InfoServer only exists because most of HttpServer was private. It could probably go away right? (Another JIRA).
I took a quick look. I'd be up for taking in this patch even if it does too much as long as it works and then working on purging stuff after it is in. This is a difficult task doing this kind of work.
Thanks [~echarles]
> Remove deprecated usage of Hadoop HttpServer in InfoServer
> ----------------------------------------------------------
>
> Key: HBASE-10336
> URL: https://issues.apache.org/jira/browse/HBASE-10336
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.99.0
> Reporter: Eric Charles
> Assignee: Eric Charles
> Attachments: 10336-v10.txt, HBASE-10336-1.patch, HBASE-10336-2.patch, HBASE-10336-3.patch, HBASE-10336-4.patch, HBASE-10336-5.patch, HBASE-10336-6.patch, HBASE-10336-7.patch, HBASE-10336-8.patch, HBASE-10336-9.patch, HBASE-10336-after-first-review-2.patch, HBASE-10336-after-first-review.patch, HBASE-10569-10.patch
>
>
> Recent changes in Hadoop HttpServer give NPE when running on hadoop 3.0.0-SNAPSHOT. This way we use HttpServer is deprecated and will probably be not fixed (see HDFS-5760). We'd better move to the new proposed builder pattern, which means we can no more use inheritance to build our nice InfoServer.
--
This message was sent by Atlassian JIRA
(v6.2#6252)