You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/09/09 05:44:49 UTC

[GitHub] [echarts] pissang opened a new pull request #15696: [fix] [type]: improve optiontypes

pissang opened a new pull request #15696:
URL: https://github.com/apache/echarts/pull/15696


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   
   
   ### What does this PR do?
   
   This PR aimed to improve option types found during the work of rewriting example code with TypeScript. It includes:
   
   1. Improve return type in `renderItem` of custom series.
   2. Export `CustomSeriesRenderItem`, `CustomSeriesRenderItemParams`, `CustomSeriesRenderItemAPI`, `CustomSeriesRenderItemReturn`
   3. More precise axis type inference based on `axis.type`.
   4. Fix callback type in `itemStyle.color` #14279 
   5. Fix `emphasis`, `blur`, `select` is `any` in some series. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15696: [fix] [type]: improve optiontypes

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15696:
URL: https://github.com/apache/echarts/pull/15696#issuecomment-915781062


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #15696: [fix] [type]: improve option types

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #15696:
URL: https://github.com/apache/echarts/pull/15696


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15696: [fix] [type]: improve option types

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15696:
URL: https://github.com/apache/echarts/pull/15696#issuecomment-915790164


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] gehringf commented on pull request #15696: [fix] [type]: improve option types

Posted by GitBox <gi...@apache.org>.
gehringf commented on pull request #15696:
URL: https://github.com/apache/echarts/pull/15696#issuecomment-923704165


   Been struggling with typing renderItem last week. Thanks for your great work! 👏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org