[GitHub] [apisix] dotSlashLu edited a comment on pull request #2222: fix: return ok in kafka-logger

[GitBox <gi...@apache.org>]

dotSlashLu edited a comment on pull request #2222:
URL: https://github.com/apache/apisix/pull/2222#issuecomment-693730801


   @ShiningRush thanks for your guide. You are right about why the error message was missed before, such a short waiting time will cover all kinds of error messages including kafka timeout and topic missing. 
   
   I've increased the waiting time and also the `batch_max_size` and `timeout` in kafka-logger setups to expose errors more quickly if there are any. Now the reproduce is stable.
   
   Before the change:
   ```
   #   Failed test 'TEST 5: access - pattern "[error]" should not match any line in error.log but matches line "2020/09/17
   07:59:38 [error] 2386#0: *20 [lua] batch-processor.lua:61: Batch Processor[kafka logger] failed to process entries: nil, context: ngx.timer, client: 127.0.0.1, server: 0.0.0.0:1984" (req 0)
   # '
   #   at /usr/local/share/perl/5.28.1/Test/Nginx/Socket.pm line 1280.
   
   #   Failed test 'TEST 5: access - pattern "[error]" should not match any line in error.log but matches line "2020/09/17
   07:59:38 [error] 2386#0: *20 [lua] batch-processor.lua:68: Batch Processor[kafka logger] exceeded the max_retry_count[1] dropping the entries, context: ngx.timer, client: 127.0.0.1, server: 0.0.0.0:1984" (req 0)
   # '
   #   at /usr/local/share/perl/5.28.1/Test/Nginx/Socket.pm line 1280.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org