You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stig Rohde Døssing (JIRA)" <ji...@apache.org> on 2017/06/01 19:28:04 UTC

[jira] [Commented] (MCHECKSTYLE-337) checkstyle:check only supports xml output format, but the docs say it supports plain as well

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033529#comment-16033529 ] 

Stig Rohde Døssing commented on MCHECKSTYLE-337:
------------------------------------------------

I have a solution working where an extra XML file is generated in the tmpdir if the outputFileFormat isn't {{xml}}. How do I put it up for review? (I'm more familiar with git where this would be done via PR)

> checkstyle:check only supports xml output format, but the docs say it supports plain as well
> --------------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-337
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-337
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>          Components: checkstyle:check
>    Affects Versions: 2.17
>            Reporter: Stig Rohde Døssing
>            Priority: Minor
>
> The documentation for the check goal at https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#outputFileFormat mentions "plain" as a valid option for file output. This is not true, the mojo only supports XML.
> I'd prefer added support for plain output, but the docs should be fixed if that is not possible.
> Taking a look at the code, it looks like the only reason plain isn't supported is because the check mojo needs to parse the output file to figure out if there were style violations. An option would be counting errors with the AuditListener instead, but this would break support for skipExec. An alternative would be to output an extra XML result file if the output format isn't XML.
> I'd be happy to implement either solution.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)