You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jhuynh1 (GitHub)" <gi...@apache.org> on 2019/12/09 18:34:05 UTC
[GitHub] [geode] jhuynh1 opened pull request #4442: Revert "Revert "Revert "GEODE-6807: cache adviseUpdate and adviseAllE…
…ventsOrCached" (#4189)" (#4212)"
This reverts commit 80efe5cae9848f4fab45bb5c199c1e1f1fdf0eae.
While working on GEODE-7510 and other distribution related issues, we noticed that this commit causes this specific test scenario to fail. It fails consistently in that it will fail within < 100 tries and without this commit, will no longer fail.
It looks like caching of the distribution profiles is possibly causing us to not do correct distribution for some reason. The end result for this test is lingering values in secondaries.
We have seen other weird scenarios but have not been able to identify the correct tests to report just yet.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/4442 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jhuynh1 commented on pull request #4442: Revert "Revert "Revert "GEODE-6807: cache adviseUpdate and adviseAllE…
Posted by "jhuynh1 (GitHub)" <gi...@apache.org>.
This is just a straight revert command. I'm trying not to cause any confusion with git and/or review. If I make modifications, I think this will cause confusion for anyone tracing this in the future.
[ Full content available at: https://github.com/apache/geode/pull/4442 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] igodwin commented on pull request #4442: Revert "Revert "Revert "GEODE-6807: cache adviseUpdate and adviseAllE…
Posted by "igodwin (GitHub)" <gi...@apache.org>.
Maybe update to use AssertJ.
[ Full content available at: https://github.com/apache/geode/pull/4442 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jhuynh1 commented on pull request #4442: Revert "Revert "Revert "GEODE-6807: cache adviseUpdate and adviseAllE…
Posted by "jhuynh1 (GitHub)" <gi...@apache.org>.
I'm not going to make modifications to this PR. It's going to be a pure revert so that things don't get munged...
[ Full content available at: https://github.com/apache/geode/pull/4442 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] igodwin commented on pull request #4442: Revert "Revert "Revert "GEODE-6807: cache adviseUpdate and adviseAllE…
Posted by "igodwin (GitHub)" <gi...@apache.org>.
AssertJ.
[ Full content available at: https://github.com/apache/geode/pull/4442 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org