You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by parthchandra <gi...@git.apache.org> on 2017/10/18 19:02:22 UTC

[GitHub] drill pull request #997: DRILL-5882: C++ Client: [Threat Modeling] Drillbit ...

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/997#discussion_r145510774
  
    --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
    @@ -595,6 +611,12 @@ connectionStatus_t DrillClientImpl::validateHandshake(DrillUserProperties* prope
     
         switch(this->m_handshakeStatus) {
             case exec::user::SUCCESS:
    +            // Check if client needs auth/encryption and server is not requiring it
    +            if(clientNeedsAuthentication(properties) || clientNeedsEncryption(properties)) {
    --- End diff --
    
    Also, do you need two different messages : auth required and encr required ?


---