You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/12/10 00:17:06 UTC
[jira] Created: (WHIRR-157) Remove service name property
Remove service name property
----------------------------
Key: WHIRR-157
URL: https://issues.apache.org/jira/browse/WHIRR-157
Project: Whirr
Issue Type: Improvement
Components: core
Reporter: Tom White
Fix For: 0.3.0
>From WHIRR-117 a cluster may run multiple services, making the service-name property redundant, since the role names in the instance template drive the bootstrapping and configuration of nodes.
We should remove it, or at least make it optional, since there may still be a need for different implementations of Service (e.g. WHIRR-125).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-157) Remove service name property
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-157:
----------------------------
Attachment: WHIRR-157.patch
Here's a straightforward patch which makes the service name optional. It passes tests.
> Remove service name property
> ----------------------------
>
> Key: WHIRR-157
> URL: https://issues.apache.org/jira/browse/WHIRR-157
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Fix For: 0.3.0
>
> Attachments: WHIRR-157.patch
>
>
> From WHIRR-117 a cluster may run multiple services, making the service-name property redundant, since the role names in the instance template drive the bootstrapping and configuration of nodes.
> We should remove it, or at least make it optional, since there may still be a need for different implementations of Service (e.g. WHIRR-125).
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WHIRR-157) Remove service name
property
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972853#action_12972853 ]
Andrei Savu edited comment on WHIRR-157 at 12/18/10 2:04 PM:
-------------------------------------------------------------
+1 Looks good. All unit tests are passing for me (& zookeeper integration tests on ec2).
was (Author: savu.andrei):
+1 Looks good. All unit tests are passing for me (+ zookeeper integration tests on ec2).
> Remove service name property
> ----------------------------
>
> Key: WHIRR-157
> URL: https://issues.apache.org/jira/browse/WHIRR-157
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Fix For: 0.3.0
>
> Attachments: WHIRR-157.patch
>
>
> From WHIRR-117 a cluster may run multiple services, making the service-name property redundant, since the role names in the instance template drive the bootstrapping and configuration of nodes.
> We should remove it, or at least make it optional, since there may still be a need for different implementations of Service (e.g. WHIRR-125).
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WHIRR-157) Remove service name property
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White resolved WHIRR-157.
-----------------------------
Resolution: Fixed
Assignee: Tom White
I've just committed this.
> Remove service name property
> ----------------------------
>
> Key: WHIRR-157
> URL: https://issues.apache.org/jira/browse/WHIRR-157
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.3.0
>
> Attachments: WHIRR-157.patch
>
>
> From WHIRR-117 a cluster may run multiple services, making the service-name property redundant, since the role names in the instance template drive the bootstrapping and configuration of nodes.
> We should remove it, or at least make it optional, since there may still be a need for different implementations of Service (e.g. WHIRR-125).
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-157) Remove service name property
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972853#action_12972853 ]
Andrei Savu commented on WHIRR-157:
-----------------------------------
+1 Looks good. All unit tests are passing for me (+ zookeeper integration tests on ec2).
> Remove service name property
> ----------------------------
>
> Key: WHIRR-157
> URL: https://issues.apache.org/jira/browse/WHIRR-157
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Fix For: 0.3.0
>
> Attachments: WHIRR-157.patch
>
>
> From WHIRR-117 a cluster may run multiple services, making the service-name property redundant, since the role names in the instance template drive the bootstrapping and configuration of nodes.
> We should remove it, or at least make it optional, since there may still be a need for different implementations of Service (e.g. WHIRR-125).
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.