[GitHub] [geronimo-metrics] diuis commented on issue #4: Accepted hosts ip range

[GitBox <gi...@apache.org>]

diuis commented on issue #4: Accepted hosts ip range
URL: https://github.com/apache/geronimo-metrics/pull/4#issuecomment-592194101
 
 
   Hi @rmannibucau ,
   thank you for your review.
   I think that a syntax like [ip1..ip2] is easier for our use case (serve the metrics api to prometheus in a k8s cluster) then the 10.[10..13].10.[0..255] syntax: sysadmins/devs/devops that manage the k8s cluster, generally express IP addresses with the CIDR notation (where, if I remember correctly the host IPs are contiguous).
   Do you see some use case where only the second octect of the IP address is a range?
   In relation to the other question, I used the InetAddress class because is imho the easier and more readable way to convert the IP address to a number that I can use to check if the client IP is in the range; and with a little patch, in this way, we can support also IPv6 format.
   Later I will do a commit to remove the BigInteger to long conversion.
   What do you think about? If you prefer, I can also implement your 10.[10..13].10.[0..255] proposed syntax, but, really, do we need it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services