You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by BJangir <gi...@git.apache.org> on 2018/07/23 16:47:18 UTC

[GitHub] carbondata pull request #2542: [CARBONDATA-2772] Size based dictionary fallb...

GitHub user BJangir opened a pull request:

    https://github.com/apache/carbondata/pull/2542

    [CARBONDATA-2772] Size based dictionary fallback is failing even thre…

    Issue:- Size Based Fallback happened even threshold is not reached.
    RootCause:- Current size calculation is wrong. it is calculated for each data. instead of generated dictionary data . 
    
    Solution :- Current size should be calculated only for generated dictionary data.
    
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
           Tests manually in 3 Node setup with 2 billion records.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BJangir/incubator-carbondata CARBONDATA-2772

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2542.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2542
    
----
commit 13219ad527a0e8d0cd6c1f46b4e132696562f5f1
Author: BJangir <ba...@...>
Date:   2018-07-23T16:44:12Z

    [CARBONDATA-2772] Size based dictionary fallback is failing even threshold is not reached.

----


---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7452/



---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by kumarvishal09 <gi...@git.apache.org>.

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    LGTM


---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6180/



---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7440/



---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6197/



---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by kumarvishal09 <gi...@git.apache.org>.

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    retest this please 


---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6211/



---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5995/



---

[GitHub] carbondata issue #2542: [CARBONDATA-2772] Size based dictionary fallback is ...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2542
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7422/



---