You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Jukka Zitting <ju...@gmail.com> on 2012/02/20 00:31:06 UTC

Fwd: lucene-solr pull request: Fixing typo in example schema: 'salves' => 'slaves'

Hi,

Here's another pull request from GitHub.

BR,

Jukka Zitting

---------- Forwarded message ----------
From: Git at Apache <gi...@git.apache.org>
Date: Sun, Feb 19, 2012 at 4:52 PM
Subject: lucene-solr pull request: Fixing typo in example schema:
'salves' => 'slaves'
To: infrastructure-dev@apache.org


GitHub user JackDanger synchronized the pull request at
https://github.com/apache/lucene-solr/pull/2

----
Fixing typo in example schema: 'salves' => 'slaves'

Just a typo in a comment. Safe to merge.
----

You can merge this pull request into a Git repository by running
$ git pull https://github.com/JackDanger/lucene-solr patch-1

Alternatively you can review and apply these changes as the patch at
https://github.com/apache/lucene-solr/pull/2.patch

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: lucene-solr pull request: Fixing typo in example schema: 'salves' => 'slaves'

Posted by Erik Hatcher <er...@gmail.com>.
What's the workflow for github pull requests?   We can't just apply the patches without the user signing off on the ASL, right?   There still needs to be a JIRA created with a patch that is checked ASL, as I understand it.

Clarification/discussion on this would be good to have.

	Erik

On Feb 19, 2012, at 18:31 , Jukka Zitting wrote:

> Hi,
> 
> Here's another pull request from GitHub.
> 
> BR,
> 
> Jukka Zitting
> 
> ---------- Forwarded message ----------
> From: Git at Apache <gi...@git.apache.org>
> Date: Sun, Feb 19, 2012 at 4:52 PM
> Subject: lucene-solr pull request: Fixing typo in example schema:
> 'salves' => 'slaves'
> To: infrastructure-dev@apache.org
> 
> 
> GitHub user JackDanger synchronized the pull request at
> https://github.com/apache/lucene-solr/pull/2
> 
> ----
> Fixing typo in example schema: 'salves' => 'slaves'
> 
> Just a typo in a comment. Safe to merge.
> ----
> 
> You can merge this pull request into a Git repository by running
> $ git pull https://github.com/JackDanger/lucene-solr patch-1
> 
> Alternatively you can review and apply these changes as the patch at
> https://github.com/apache/lucene-solr/pull/2.patch
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org