You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/01 12:24:06 UTC

[GitHub] [pulsar] tongsucn opened a new pull request #9106: [cpp-client] Fix compilation issue caused by non-virtual destructor

tongsucn opened a new pull request #9106:
URL: https://github.com/apache/pulsar/pull/9106


   Related issue: #9105


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #9106: [cpp-client] Fix compilation issue caused by non-virtual destructor

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9106:
URL: https://github.com/apache/pulsar/pull/9106#issuecomment-753617033


   @tongsucn Could you please rebase the master branch since there is a test fix in the master branch? It's better do not use the master branch to push PRs. For more details, you can refer to http://pulsar.apache.org/en/contributing/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] jiazhai commented on pull request #9106: [cpp-client] Fix compilation issue caused by non-virtual destructor

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9106:
URL: https://github.com/apache/pulsar/pull/9106#issuecomment-753550131


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie merged pull request #9106: [cpp-client] Fix compilation issue caused by non-virtual destructor

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9106:
URL: https://github.com/apache/pulsar/pull/9106


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] tongsucn commented on pull request #9106: [cpp-client] Fix compilation issue caused by non-virtual destructor

Posted by GitBox <gi...@apache.org>.
tongsucn commented on pull request #9106:
URL: https://github.com/apache/pulsar/pull/9106#issuecomment-753803038


   @codelipenghui It's done, sorry for my fault. I'll use another branch next time :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #9106: [cpp-client] Fix compilation issue caused by non-virtual destructor

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9106:
URL: https://github.com/apache/pulsar/pull/9106#issuecomment-754106797


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] tongsucn commented on pull request #9106: [cpp-client] Fix compilation issue caused by non-virtual destructor

Posted by GitBox <gi...@apache.org>.
tongsucn commented on pull request #9106:
URL: https://github.com/apache/pulsar/pull/9106#issuecomment-753566328


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org