[GitHub] [samza] cameronlee314 commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka 
URL: https://github.com/apache/samza/pull/941#discussion_r263575676
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/storage/TaskSideInputStorageManager.java
 ##########
 @@ -74,7 +74,7 @@
   private final SystemAdmins systemAdmins;
   private final TaskName taskName;
   private final TaskMode taskMode;
-  private final Map<SystemStreamPartition, String> lastProcessedOffsets = new ConcurrentHashMap<>();
 
 Review comment:
   I was trying to clarify that this field no longer stored the actual "last processed offsets", since we now need to store the "checkpoint offset" for writing to the offset files.
   Do you think we should also track the actual "last processed offsets" explicitly for the metric? Or would the "checkpoint offset" be sufficient for the metric?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services