[jira] [Resolved] (IMPALA-4168) Adopt Oracle-style hint placement for INSERT statements

["Dimitris Tsirogiannis (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-4168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitris Tsirogiannis resolved IMPALA-4168.
-------------------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.12.0

Change-Id: Ied7629d70197a0270cdc0853e00cc021fdb4dc20
Reviewed-on: http://gerrit.cloudera.org:8080/8676
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M testdata/workloads/functional-planner/queries/PlannerTest/insert.test
M testdata/workloads/functional-planner/queries/PlannerTest/kudu-upsert.test
8 files changed, 265 insertions(+), 84 deletions(-)

> Adopt Oracle-style hint placement for INSERT statements
> -------------------------------------------------------
>
>                 Key: IMPALA-4168
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4168
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Frontend
>    Affects Versions: Impala 2.2, Impala 2.3.0, Impala 2.5.0, Impala 2.4.0, Impala 2.6.0, Impala 2.7.0
>            Reporter: Alexander Behm
>            Assignee: Jinchul Kim
>              Labels: incompatibility, ramp-up
>             Fix For: Impala 2.12.0
>
>
> For consistency with Oracle we should consider accepting hints in the same places in SQL statements. For example, our current INSERT statements accepts hints right before the SELECT portion:
> {code}
> INSERT INTO t PARTITIONED(year,month) /*+ hints */ SELECT * FROM src;
> {code}
> The proposal is to accept hints immediately after INSERT like Oracle does:
> {code}
> INSERT /*+ hints */ INTO t PARTITIONED(year,month) SELECT * FROM src;
> {code}
> Ideally, we would not accept hints in multiple places to avoid confusion and to reduce the code and testing burden. Ceasing to recognize the old hint placement is a backwards incompatible change.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)