You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/25 03:44:10 UTC

[GitHub] [rocketmq-exporter] francisoliverlee commented on a change in pull request #32: Support ACL

francisoliverlee commented on a change in pull request #32:
URL: https://github.com/apache/rocketmq-exporter/pull/32#discussion_r530088748



##########
File path: src/main/java/org/apache/rocketmq/exporter/config/RMQConfigure.java
##########
@@ -44,6 +44,16 @@
 
     private volatile String rocketmqVersion = System.getProperty(ROCKETMQ_CONFIG_ROCKETMQ_VERSION, "V4_3_2");
 
+    private String accessKey;
+
+    private String secretKey;
+
+    public boolean enableACL() {
+        return !(StringUtils.isAllBlank(this.accessKey)
+                &&
+                StringUtils.isAllBlank(this.secretKey));
+    }
+

Review comment:
       LGTM and updated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org