You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/02/08 04:24:09 UTC
[GitHub] [bigtop] sekikn opened a new pull request #727: BIGTOP-3488. Bump Kafka to 2.4.1.
sekikn opened a new pull request #727:
URL: https://github.com/apache/bigtop/pull/727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #727: BIGTOP-3488. Bump Kafka to 2.4.1.
Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #727:
URL: https://github.com/apache/bigtop/pull/727#issuecomment-775161680
Updated the PR. I chose rewriting dependencies.gradle in do-component-build rather than putting a patch in bigtop-packages/src/common/kafka, so that we can leverage `$ZOOKEEPER_VERSION` instead of a hard-coded value.
I confirmed the right version of ZK was used by checking the following message, which is output by install_kafka.sh.
```
+ rm -f debian/kafka//usr/lib/kafka/libs/zookeeper-3.4.14.jar
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #727: BIGTOP-3488. Bump Kafka to 2.4.1.
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #727:
URL: https://github.com/apache/bigtop/pull/727#issuecomment-775089037
@sekikn. Should we patch dependencies.gradle in order to set the zookeeper version to 3.4.14? It would be useful to find compilation issue and pull exact transitive dependencies of zookeeper-3.4.14.
```
diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 7597b9c52..dab290372 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -114,7 +114,7 @@ versions += [
spotbugs: "3.1.12",
spotbugsPlugin: "1.6.9",
spotlessPlugin: "3.23.1",
- zookeeper: "3.5.7",
+ zookeeper: "3.4.14",
zstd: "1.4.3-1"
]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #727: BIGTOP-3488. Bump Kafka to 2.4.1.
Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #727:
URL: https://github.com/apache/bigtop/pull/727#issuecomment-775150533
Oh, that's right. I mistakenly thought that the zookeeper version was specified in do-component-build just like other components. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #727: BIGTOP-3488. Bump Kafka to 2.4.1.
Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #727:
URL: https://github.com/apache/bigtop/pull/727#issuecomment-774858262
Tested on CentOS 7 and 8, Debian 10 and Ubuntu 18.04.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims merged pull request #727: BIGTOP-3488. Bump Kafka to 2.4.1.
Posted by GitBox <gi...@apache.org>.
iwasakims merged pull request #727:
URL: https://github.com/apache/bigtop/pull/727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org