[GitHub] [accumulo] keith-turner commented on a change in pull request #1646: fixes #1644: minor compaction retry

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1646:
URL: https://github.com/apache/accumulo/pull/1646#discussion_r447983392



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java
##########
@@ -148,6 +149,13 @@ public CompactionStats call() {
           reportedProblem = true;
         } catch (CompactionCanceledException e) {
           throw new IllegalStateException(e);
+        } catch (Throwable t) {

Review comment:
       ```suggestion
           } catch (Error t) {
   ```
   
   Catching throwable will mask checked exceptions in future code changes.  For example if the checked exceptions on a method called here are changed, and those checked exceptions should be handled.. then catching Throwable would hide the need to handle those.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org