[jira] [Commented] (HADOOP-7949) Server maxIdleTime is way too low

["Harsh J (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179276#comment-13179276 ] 

Harsh J commented on HADOOP-7949:
---------------------------------

+1, the changes look good to me. Thanks for 'constantizing' this!
                
> Server maxIdleTime is way too low
> ---------------------------------
>
>                 Key: HADOOP-7949
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7949
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.21.0, 0.22.0, 0.23.0, 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hadoop-7949.txt
>
>
> HADOOP-2909 intended to set the server max idle time for a connection to twice the client value. ("The server-side max idle time should be greater than the client-side max idle time, for example, twice of the client-side max idle time.") This way when a server times out a connection it's due a crashed client and not an inactive client so we don't close client connections with outstanding requests (by setting 2x the client value on the server side the client should time out the connection first).
> Looks like there was a typo in the patch and it set the default value to 1/5th the client value, instead of the intended 2x.
> {noformat}
> hadoop2 (pre-HADOOP-4687)$ git reset --hard 6fa4597e
> hadoop2 (pre-HADOOP-4687)$ grep -r ipc.client.connection.maxidletime . 
> ./src/core/org/apache/hadoop/ipc/Client.java:      conf.getInt("ipc.client.connection.maxidletime", 10000); //10s
> ./src/core/org/apache/hadoop/ipc/Server.java:    this.maxIdleTime = 2*conf.getInt("ipc.client.connection.maxidletime", 1000);
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira